Bug 223037 - Typo in Mk/uses/objc.mk
Summary: Typo in Mk/uses/objc.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-15 22:26 UTC by Brooks Davis
Modified: 2017-10-16 08:04 UTC (History)
3 users (show)

See Also:


Attachments
fix USES objc (590 bytes, patch)
2017-10-15 22:27 UTC, Brooks Davis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer 2017-10-15 22:26:10 UTC
I noticed this sanity check error on fresh ports after it failed to update a dependency for games/oolite:

https://www.freshports.org/sanity_test_failures.php?message_id=201708211326.v7LDQTpS021179@repo.freebsd.org
---
games/oolite:

This command (FreshPorts code 1):

/usr/local/bin/sudo /usr/sbin/chroot -u dan /usr/FreshPorts/ports-jail
/make-port.sh /usr/local/PORTS-head games/oolite
2>/tmp/FreshPorts.games.oolite.make-error.2017.8.21.13.27.44.63651

produced this error:

Error message is: make: "/usr/local/PORTS-head/Mk/Uses/objc.mk" line 46:
Malformed conditional (${ALT_COMPILER_TYPE} == clang &&
${ALT_COMPILER_VERSION} >= ${OJBC_CLANG_VERSION})
make: Fatal errors encountered -- cannot continueMake results are : 
make: stopped in /usr/local/PORTS-head/games/oolite
---

They misspelling of OBJC_CLANG_VERSION is obvious.
Comment 1 Brooks Davis freebsd_committer 2017-10-15 22:27:18 UTC
Created attachment 187203 [details]
fix USES objc
Comment 2 Brooks Davis freebsd_committer 2017-10-15 22:28:12 UTC
Adding Dan as fresh ports may need a manual rerun of the effected ports after this is fixed.
Comment 3 commit-hook freebsd_committer 2017-10-16 08:02:17 UTC
A commit references this bug:

Author: bapt
Date: Mon Oct 16 08:01:34 UTC 2017
New revision: 452178
URL: https://svnweb.freebsd.org/changeset/ports/452178

Log:
  Fix typo

  PR:		223037
  Submitted by:	brooks
  MFH:		2017Q4

Changes:
  head/Mk/Uses/objc.mk
Comment 4 commit-hook freebsd_committer 2017-10-16 08:04:24 UTC
A commit references this bug:

Author: bapt
Date: Mon Oct 16 08:03:29 UTC 2017
New revision: 452179
URL: https://svnweb.freebsd.org/changeset/ports/452179

Log:
  MFH: r452178

  Fix typo

  PR:		223037
  Submitted by:	brooks

Changes:
_U  branches/2017Q4/
  branches/2017Q4/Mk/Uses/objc.mk