Bug 223108 - www/uwsgi: Add support for non-default Python versions, Take MAINTAINER'ship
Summary: www/uwsgi: Add support for non-default Python versions, Take MAINTAINER'ship
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2017-10-19 09:20 UTC by schmidt
Modified: 2017-11-16 06:49 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (schmidt)


Attachments
Update patch (3.35 KB, patch)
2017-10-19 09:22 UTC, schmidt
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description schmidt 2017-10-19 09:20:29 UTC
Setting PYTHON_VERSION allows to build uwsgi agains a different python version than default python. Changed the package name accordingly to allow installation of multiple uWSGI Packages. 
Added rc.conf variable to select the executed binary. 

I would like to takeover maintainership of this port as I'm using it in production systems.
Comment 1 schmidt 2017-10-19 09:22:54 UTC
Created attachment 187300 [details]
Update patch
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-11-06 10:04:38 UTC
Thank you for your contribution Gerhard.

The attached patch needs changes, but I don't have time for a full review tonight.

Please run the port through portlint -AC and poudriere with DEVELOPER=yes enabled, and submit an updated patch which addresses any issues identified. For testing information and instructions, see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html

Above that, some obvious issues:

- Remove PYTHON_PKGNAMEPREFIX from PORTNAME. For correct usage see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#using-python

- Use CHEESESHOP as MASTER_SITES by default unless there's a compelling temporary reason not to (eg: alternate source contains test files/test data)

- Use USE_PYTHON=autoplist
- Use USE_PYTHON=concurrent to do automatic suffixing of console scripts installed in LOCALBASE/bin

These are both documented in the link above as well.

- Explain the gettext-runtime addition

Lastly, thank you for offering to take maintainership of a FreeBSD port
Comment 3 schmidt 2017-11-16 06:49:48 UTC
I see that someone has already taken maintainership of this port i send him/her an updated patch for inclusion.