Bug 223202 - emulators/virtualbox-ose-nox11: can't build with error
Summary: emulators/virtualbox-ose-nox11: can't build with error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-24 06:41 UTC by hashiz
Modified: 2017-10-24 22:36 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (vbox)


Attachments
Fixes a build when X11 option is off (1.36 KB, patch)
2017-10-24 10:36 UTC, Alexander Zagrebin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hashiz 2017-10-24 06:41:27 UTC
emulators/virtualbox-ose-nox11 can't build with following errors.

$ portupgrade -ps -N emulators/virtualbox-ose-nox11
- snip -
kBuild: Compiling VBoxGuestPropSvc - /usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/GuestProperties/service.cpp
kBuild: Compiling VBoxGuestControlSvc - /usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/GuestControl/service.cpp
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:58:20: error:
      too many arguments provided to function-like macro invocation
    NOREF(pClient, fHeadless);
                   ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/include/iprt/cdefs.h:2949:9: note:
      macro 'NOREF' defined here
#define NOREF(var)               (void)(var)
        ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:58:5: error:
      use of undeclared identifier 'NOREF'
    NOREF(pClient, fHeadless);
    ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:94:20: error:
      too many arguments provided to function-like macro invocation
    NOREF(pClient, u32Formats);
                   ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/include/iprt/cdefs.h:2949:9: note:
      macro 'NOREF' defined here
#define NOREF(var)               (void)(var)
        ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:94:5: error:
      use of undeclared identifier 'NOREF'
    NOREF(pClient, u32Formats);
    ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:110:20: error:
      too many arguments provided to function-like macro invocation
    NOREF(pClient, u32Format, pv, cb);
                   ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/include/iprt/cdefs.h:2949:9: note:
      macro 'NOREF' defined here
#define NOREF(var)               (void)(var)
        ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:110:5: error:
      use of undeclared identifier 'NOREF'
    NOREF(pClient, u32Format, pv, cb);
    ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:128:20: error:
      too many arguments provided to function-like macro invocation
    NOREF(pClient, pv, cb, u32Format);
                   ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/include/iprt/cdefs.h:2949:9: note:
      macro 'NOREF' defined here
#define NOREF(var)               (void)(var)
        ^
/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp:128:5: error:
      use of undeclared identifier 'NOREF'
    NOREF(pClient, pv, cb, u32Format);
    ^
8 errors generated.
kmk: *** [/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/out/freebsd.amd64/release/obj/VBoxSharedClipboard/x11-stub.o] Error 1
The failing command:
@c++ -c -O2 -g -pipe -Wshadow -Wall -Wextra -Wno-missing-field-initializers -Wno-unused -Wno-trigraphs -fdiagnostics-show-option -Wno-unused-parameter -Wno-language-extension-token -Wno-extended-offsetof -Wno-gnu-folding-constant  -Wno-string-plus-int -Wno-nested-anon-types -Wno-variadic-macros -Wno-long-long -Wno-variadic-macros -O2 -mtune=generic -fno-omit-frame-pointer -fno-strict-aliasing -fvisibility=hidden -DVBOX_HAVE_VISIBILITY_HIDDEN -DRT_USE_VISIBILITY_DEFAULT -fvisibility-inlines-hidden  -fPIC -m64 -I/usr/local/include -I/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/out/freebsd.amd64/release/obj/VBoxSharedClipboard/dtrace -I/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/include -I/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/out/freebsd.amd64/release -DVBOX -DVBOX_OSE -DVBOX_WITH_64_BITS_GUESTS -DVBOX_WITH_REM -DVBOX_WITH_RAW_MODE -DRT_OS_FREEBSD -D__FREEBSD__ -DRT_ARCH_AMD64 -D__AMD64__ -DVBOX_WITH_DEBUGGER -DVBOX_WITH_HARDENING -DRTPATH_APP_PRIVATE=\"/usr/local/share/virtualbox-ose\" -DRTPATH_APP_PRIVATE_ARCH=\"/usr/local/lib/virtualbox\" -DRTPATH_SHARED_LIBS=\"/usr/local/lib/virtualbox\" -DRTPATH_APP_DOCS=\"/usr/local/share/doc/virtualbox-ose\" -DIN_RING3 -DHC_ARCH_BITS=64 -DGC_ARCH_BITS=64 -DPIC -DVBOX_WITH_HGCM -Wp,-MD,/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/out/freebsd.amd64/release/obj/VBoxSharedClipboard/x11-stub.o.dep -Wp,-MT,/usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/out/freebsd.amd64/release/obj/VBoxSharedClipboard/x11-stub.o -Wp,-MP -o /usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/out/freebsd.amd64/release/obj/VBoxSharedClipboard/x11-stub.o /usr/ports/emulators/virtualbox-ose-nox11/work/VirtualBox-5.2.0/src/VBox/HostServices/SharedClipboard/x11-stub.cpp
kmk: *** Waiting for unfinished jobs....
kmk: *** Exiting with status 2
*** Error code 2

Stop.
make[1]: stopped in /usr/ports/emulators/virtualbox-ose-nox11
*** Error code 1

Stop.
make: stopped in /usr/ports/emulators/virtualbox-ose-nox11
** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade20171024-36787-jtquzu env make"DEPENDS_TARGET=install package"
** Fix the problem and try again.
--->  [Executing a command as root: sudo /usr/local/sbin/pkgdb -aFOQ]
** Listing the failed packages (-:ignored / *:skipped / !:failed)
        ! emulators/virtualbox-ose-nox11        (unknown build error)
$
Comment 1 Alexander Zagrebin 2017-10-24 10:36:05 UTC
Created attachment 187420 [details]
Fixes a build when X11 option is off

I can confirm that.
Try the attached patch.
Comment 2 Alexander Zagrebin 2017-10-24 10:37:40 UTC
I can confirm that.
Try the attached patch.
Comment 3 Dutchman01 2017-10-24 17:31:52 UTC
patch works!
Comment 4 Jung-uk Kim freebsd_committer 2017-10-24 18:20:44 UTC
I'll take it.
Comment 5 commit-hook freebsd_committer 2017-10-24 22:36:23 UTC
A commit references this bug:

Author: jkim
Date: Tue Oct 24 22:35:37 UTC 2017
New revision: 452821
URL: https://svnweb.freebsd.org/changeset/ports/452821

Log:
  Fix emulators/virtualbox-ose-nox11 build.

  PR:		223202

Changes:
  head/emulators/virtualbox-ose/files/patch-src_VBox_HostServices_SharedClipboard_x11-stub.cpp
Comment 6 Jung-uk Kim freebsd_committer 2017-10-24 22:36:58 UTC
Committed, thanks!