Bug 223266 - audio/suil: update port to latest version of suil
Summary: audio/suil: update port to latest version of suil
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-26 20:09 UTC by Michael Beer
Modified: 2017-12-08 17:45 UTC (History)
1 user (show)

See Also:


Attachments
svn diff of port files (2.69 KB, patch)
2017-10-26 20:09 UTC, Michael Beer
no flags Details | Diff
svn diff of port files (3.43 KB, patch)
2017-11-05 21:24 UTC, Michael Beer
beerml: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Beer 2017-10-26 20:09:16 UTC
Created attachment 187502 [details]
svn diff of port files

update to suil v0.10.0

adds support for for QT5 widgets in gtk2 and vice versa
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-27 05:12:20 UTC
Hi Michael

To depend on Qt[45] you should use the USE_QT4=... and USE_QT5=... respectively functionnality.

[But that will prohibit you from depending on different versions at the same time].


If the toolkit-parts can be built separately, how about creating slave-ports for them?



mfg Tobias
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-27 05:17:44 UTC
You could also use options like

OPTIONS_MULTI=TOOLKIT
OPTIONS_MULTI_TOOLKIT=GTK2 GTK3 QT4 QT5

QT4_USE= QT4=corelib,gui
[...]

QT4_PREVENTS= QT5
[...]
Comment 3 Michael Beer 2017-10-28 19:47:36 UTC
I already thought about using options.
However my conclusion was that in case you have to
use this library, you very likely have a full featured
desktop installation anyway using all of these toolkits already.

So, if using options my default would definitely be
using all toolkits.
However I've not objections in opting out some of them.
I'm just not sure how this can be reflected in the pkg-plist file!?

Michael
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-28 20:54:15 UTC
You can mask plist entries via PLIST_SUBs

https://www.freebsd.org/doc/en/books/porters-handbook/plist.html
Comment 5 Michael Beer 2017-11-05 21:24:01 UTC
Created attachment 187769 [details]
svn diff of port files

New version for the update.
This allows now to disable QT4 or/and QT5 support.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2017-12-08 17:44:57 UTC
I've also simplified stripping. You can strip all .so files with one command.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-12-08 17:45:15 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Dec  8 17:44:33 UTC 2017
New revision: 455787
URL: https://svnweb.freebsd.org/changeset/ports/455787

Log:
  - Update to 0.10.0
  - Optionize Qt4/Qt5 support

  PR:		223266
  Submitted by:	beerml@sigma6audio.de (maintainer)

Changes:
  head/audio/suil/Makefile
  head/audio/suil/distinfo
  head/audio/suil/pkg-plist