Bug 223292 - multimedia/kodi: Fix packaging on 11-STABLE/arm with RPI2 option
Summary: multimedia/kodi: Fix packaging on 11-STABLE/arm with RPI2 option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Luca Pizzamiglio
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-10-28 19:07 UTC by Jonathan Chen
Modified: 2017-11-20 14:16 UTC (History)
4 users (show)

See Also:
mickael.maillot: maintainer-feedback+
pizzamig: merge-quarterly-


Attachments
Fix build for RPI2 on 11-STABLE (3.92 KB, patch)
2017-10-28 19:07 UTC, Jonathan Chen
koobs: maintainer-approval? (mickael.maillot)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2017-10-28 19:07:13 UTC
Created attachment 187546 [details]
Fix build for RPI2 on 11-STABLE

Attempting to build multimedia/kodi on 11-STABLE/arm with the RPI2 option set will result in a failure during the packaging phase:

===>  Building package for kodi-17.3_2
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.kodi.adsp/libKODI_adsp-armv6-freebsd.so:No s
uch file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.kodi.audioengine/libKODI_audioengine-armv6-f
reebsd.so:No such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.kodi.guilib/libKODI_guilib-armv6-freebsd.so:
No such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.kodi.inputstream/libKODI_inputstream-armv6-f
reebsd.so:No such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.kodi.peripheral/libKODI_peripheral-armv6-fre
ebsd.so:No such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.xbmc.addon/libXBMC_addon-armv6-freebsd.so:No
 such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.xbmc.codec/libXBMC_codec-armv6-freebsd.so:No
 such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/addons/library.xbmc.pvr/libXBMC_pvr-armv6-freebsd.so:No suc
h file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/system/libcpluff-armv6-freebsd.so:No such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/system/libexif-armv6-freebsd.so:No such file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/system/players/VideoPlayer/libdvdcss-armv6-freebsd.so:No su
ch file or directory
pkg-static: Unable to access file /construction/xports/multimedia/kodi/work/stag
e/usr/local/lib/kodi/system/players/VideoPlayer/libdvdnav-armv6-freebsd.so:No su
ch file or directory
*** Error code 1

This is because patch-configure.ac assumes that all RPI2 builds will result in armv7 TARGET_ARCH; but this is only valid for 12-CURRENT, and not 11-STABLE.

Attached patch to fix.
Comment 1 Luca Pizzamiglio freebsd_committer freebsd_triage 2017-11-07 17:08:20 UTC
I've tested the build using the patch on head and it works.

Unfortunately, the patch doesn't apply on 2017Q4.
Is this problem also affecting on 2017Q4?
Comment 2 Jonathan Chen 2017-11-14 18:26:33 UTC
I don't think the armv7 changes went into the quarterly branch. Portmeisters will be able to give you a more definitive answer.
Comment 3 Luca Pizzamiglio freebsd_committer freebsd_triage 2017-11-20 12:50:48 UTC
I won't merge this PR to quarterly, because the patch doesn't apply and quarterly misses previous commits
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2017-11-20 13:50:24 UTC
fwiw kodi 17.6 was released a few days ago, it's probably time to update it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-11-20 14:13:16 UTC
A commit references this bug:

Author: pizzamig
Date: Mon Nov 20 14:12:20 UTC 2017
New revision: 454563
URL: https://svnweb.freebsd.org/changeset/ports/454563

Log:
  multimedia/kodi: Fix RPI2 support on 11.x

  PR:		223292
  Submitted by:	jonc@chen.org.nz
  Reviewed by:	mickael.maillot@gmail.com (maintainer)
  Approved by:	olivier (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13168

Changes:
  head/multimedia/kodi/files/patch-configure.ac
Comment 6 Luca Pizzamiglio freebsd_committer freebsd_triage 2017-11-20 14:16:13 UTC
Committed, thanks! Sorry for the long wait.