Bug 223309 - net/subnetcalc: Update to 2.4.8
Summary: net/subnetcalc: Update to 2.4.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Tobias C. Berner
URL: https://www.uni-due.de/~be0001/subnet...
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-29 19:03 UTC by Thomas Dreibholz
Modified: 2017-10-31 18:48 UTC (History)
1 user (show)

See Also:

Attachments
The diff to update the subnetcalc port (1.97 KB, patch)
2017-10-29 19:03 UTC, Thomas Dreibholz 		no flags Details | Diff
The updated diff file (1.32 KB, patch)
2017-10-30 20:27 UTC, Thomas Dreibholz 		no flags Details | Diff
The updated diff file (2.37 KB, patch)
2017-10-30 20:33 UTC, Thomas Dreibholz 		no flags Details | Diff
The updated diff file (1.32 KB, patch)
2017-10-30 20:34 UTC, Thomas Dreibholz 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Dreibholz 2017-10-29 19:03:22 UTC 
Created attachment 187567 [details]
The diff to update the subnetcalc port

The latest upstream version of net/subnetcalc is 2.4.8; the port needs an update.

Fix: The updated diff file is attached.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-29 21:18:17 UTC 
Hi there

1) Why do you switch out USES=gmake by USE_GMAKE=yes?
2) The header of the Makefile should only contain the $FreeBSD$ one, the rest is not current style. See the note to 3.1 in [1]
3) Use portlint and try to make it happy :)


[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/quick-porting.html#porting-makefile
Comment 2 Thomas Dreibholz 2017-10-30 20:27:27 UTC 
Created attachment 187590 [details]
The updated diff file

The problems should be fixed in the updated diff.
Comment 3 Thomas Dreibholz 2017-10-30 20:33:13 UTC 
Created attachment 187593 [details]
The updated diff file

The URL was still wrong. Fixed.
Comment 4 Thomas Dreibholz 2017-10-30 20:34:15 UTC 
Created attachment 187594 [details]
The updated diff file

Finally, the right patch.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-31 18:48:22 UTC 
A commit references this bug:

Author: tcberner
Date: Tue Oct 31 18:47:52 UTC 2017
New revision: 453247
URL: https://svnweb.freebsd.org/changeset/ports/453247

Log:
  Update net/subnetcalc to 2.4.8

  PR:		223309
  Submitted by:	dreibh@iem.uni-due.de (maintainer)

Changes:
  head/net/subnetcalc/Makefile
  head/net/subnetcalc/distinfo
  head/net/subnetcalc/pkg-descr
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-31 18:48:37 UTC 
Committed. Thanks :)