Bug 223310 - sysutils/xfce4-genmon-plugin: Update to 4.0.1
Summary: sysutils/xfce4-genmon-plugin: Update to 4.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-10-29 19:28 UTC by Olivier Duchateau
Modified: 2017-10-29 22:38 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
Patch to update sysutils/xfce4-genmon-plugin (1.25 KB, patch)
2017-10-29 19:28 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2017-10-29 19:28:55 UTC 
Created attachment 187568 [details]
Patch to update sysutils/xfce4-genmon-plugin

- Update to 4.0.1
- Make portlint happy
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2017-10-29 20:13:54 UTC 
I'm testing a similar patch myself. You were quite fast.

BTW I noticed you're adding USE_LDCONFIG=yes, but that's not really necessary even if portlint says it is. While the ports does install a library it's not a library for other software to link against using the system linker, it's loaded dynamically by the panel.

Also, setting USE_LDCONFIG=yes is equivalent to setting it to ${PREFIX}/lib, and that's the only directory new libraries will be looked up when installing, so, since this port installs it's .so library in another location, this is really a nop.

I also noticed other xfce4 ports have USE_LDCONFIg set, but not really needing it. No need to perform a commit just to remove that but I wil try to remember to clean that in the future.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2017-10-29 22:37:51 UTC 
Committed. Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-10-29 22:38:09 UTC 
A commit references this bug:

Author: madpilot
Date: Sun Oct 29 22:37:40 UTC 2017
New revision: 453143
URL: https://svnweb.freebsd.org/changeset/ports/453143

Log:
  Update xfce4-genmon-plugin to 4.0.1

  PR:		223310
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>

Changes:
  head/sysutils/xfce4-genmon-plugin/Makefile
  head/sysutils/xfce4-genmon-plugin/distinfo