Bug 223399 - [PATCH] devel/gitflow update to 1.11.0 and use petervanderdoes fork
Summary: [PATCH] devel/gitflow update to 1.11.0 and use petervanderdoes fork
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-11-03 09:31 UTC by Aldis Berjoza
Modified: 2017-12-07 20:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (nbari)

Attachments
update gitflow to petervanderdoes/gitflow-avh 1.11.0 (2.39 KB, patch)
2017-11-03 09:31 UTC, Aldis Berjoza 		no flags Details | Diff
patch (2.93 KB, patch)
2017-12-07 19:20 UTC, Carlos J. Puga Medina 		cpm: maintainer-approval? (nbari)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aldis Berjoza 2017-11-03 09:31:31 UTC 
Created attachment 187686 [details]
update gitflow to petervanderdoes/gitflow-avh 1.11.0

This fork is still maintained https://github.com/petervanderdoes/gitflow-avh and has some very neat features. For example it has support for automatically signing tags when creating new releases.

It also has extensive documentation: https://github.com/petervanderdoes/gitflow-avh/wiki unlike current fork.

Attached patch changes gitflow to petervanderdoes/gitflow-avh and updates version to 1.11.0.

Please review changes to the port I made about license.
Original gitflow was licenses un der BSD2CLAUSE license, but petervanderdoes/gitflow-avh licenses changes under LGPL2.1.

As far as I understand I should set both licenses in port, but please check this.
Comment 1 nbari 2017-11-03 09:34:40 UTC 
Hi Aldis, thanks for checking this out, it looks fine from my side.

regards
Comment 2 nbari 2017-11-03 09:51:32 UTC 
Just in case here is the Poudriere success log: http://build.affe.network/data/11amd64-custom/2017-11-03_09h46m04s/logs/gitflow-1.11.0.log
Comment 3 nbari 2017-11-03 09:51:49 UTC 
Just in case here is the Poudriere success log: http://build.affe.network/data/11amd64-custom/2017-11-03_09h46m04s/logs/gitflow-1.11.0.log
Comment 4 Aldis Berjoza 2017-12-03 20:16:38 UTC 
Any reason for the delay merging?
Comment 5 nbari 2017-12-03 20:20:46 UTC 
Asking me the same thing :/
Comment 6 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-12-07 19:20:49 UTC 
Created attachment 188617 [details]
patch

- Fix LICENSE block
- Add GH_PROJECT variable to avoid modifying WRKSRC manually
Comment 7 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-12-07 19:23:35 UTC 
(In reply to Carlos J. Puga Medina from comment #6)

I forgot to mention another change:

- Update pkg-descr
Comment 8 nbari 2017-12-07 19:30:01 UTC 
It’s ok, thanks
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-12-07 20:04:02 UTC 
A commit references this bug:

Author: cpm
Date: Thu Dec  7 20:03:30 UTC 2017
New revision: 455753
URL: https://svnweb.freebsd.org/changeset/ports/455753

Log:
  devel/gitflow: update to 1.11.0

  - Update LICENSE
  - Update GH_* variables to the new repository
  - Update comment and WWW in pkg-descr

  Changelog: https://github.com/petervanderdoes/gitflow-avh/releases/tag/1.11.0

  PR:		223399
  Submitted by:	Aldis Berjoza <aldis@berjoza.lv>
  Approved by:	Nicolas Embriz <nbari@tequila.io> (maintainer)

Changes:
  head/devel/gitflow/Makefile
  head/devel/gitflow/distinfo
  head/devel/gitflow/pkg-descr
  head/devel/gitflow/pkg-plist
Comment 10 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-12-07 20:05:44 UTC 
Committed, thanks!