Currently, it always warns:
> WARN: /usr/ports/multimedia/simplescreenrecorder/pkg-plist: : installing icons, please define INSTALLS_ICONS as appropriate
Handbook says that it is only needed for GTK+ ports: https://www.freebsd.org/doc/en/books/porters-handbook/using-gnome.html
You should print the above warning only for GTK+ ports, but warn when INSTALLS_ICONS is set for non-GTK+ ports.
Another thing is that the warning is printed a lot of times. One time is enough.
Created attachment 188072 [details]
Patch to suppress INSTALLS_ICONS warning for Qt5 ports
This patch adds a `needs_installs_icons()` which states whether a port needs INSTALLS_ICONS when there are icons present. It's pessimistic, to preserve existing warnings and only suppress the warning for Qt5-based applications.
Additionally, checks for INSTALLS_ICONS when it isn't needed (i.e. Qt5).
The `needs_installs_icons()` function could be massaged to really check only for GNOME ports, but this seems simpler.
Adding tcberner@ (mentor for me and yuri) and rakuco@ (mentor for me).
This sounds like a good idea.
Fix committed to my repo pending the next release.