Bug 223536 - www/yarn: Add support for www/node8 now that www/node is v.9
Summary: www/yarn: Add support for www/node8 now that www/node is v.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-08 14:01 UTC by Daniel Ylitalo
Modified: 2017-11-09 17:26 UTC (History)
2 users (show)

See Also:


Attachments
Adds support for www/node8 (765 bytes, patch)
2017-11-08 14:01 UTC, Daniel Ylitalo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ylitalo 2017-11-08 14:01:44 UTC
Created attachment 187859 [details]
Adds support for www/node8

The provided patch adds support for the now created www/node8 port

Passes poudriere testport
Comment 1 commit-hook freebsd_committer 2017-11-09 16:56:35 UTC
A commit references this bug:

Author: pizzamig
Date: Thu Nov  9 16:55:36 UTC 2017
New revision: 453849
URL: https://svnweb.freebsd.org/changeset/ports/453849

Log:
  www/yarn: Add support to www/node8

  Moreover, adopt www/node8 as default option.

  PR:		223536
  Submitted by:	daniel@blodan.se
  Approved by:	olivier (mentor)
  Sponsored by:	trivago N.V.
  Differential Revision:	https://reviews.freebsd.org/D13006

Changes:
  head/www/yarn/Makefile
Comment 2 Luca Pizzamiglio freebsd_committer 2017-11-09 16:58:27 UTC
Thanks for the contribution.

I reworked the patch a little to be aligned with npm.
The default option is now NODE8, like in npm.
For this reason, I bumped the portrevision
Comment 3 Daniel Ylitalo 2017-11-09 17:14:22 UTC
Hi,

Just for your information, www/npm uses node 9.1 as default version (www/node) so you now made yarn inconsistent with the npm port :)
Comment 4 Luca Pizzamiglio freebsd_committer 2017-11-09 17:26:34 UTC
(In reply to Daniel Ylitalo from comment #3)

That's partially true.
I did it to be consistent with your patch on www/npm.
Currently, www/npm has as DEFAULT_OPTIONS NODE8, even if is still pointing to www/node.

When your patch on www/npm will be applied, it will be consistent again.