Bug 223549 - textproc/ibus: Update to 1.5.17
Summary: textproc/ibus: Update to 1.5.17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-09 00:54 UTC by Yuri Victorovich
Modified: 2017-12-03 19:23 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (henry.hu.sh)

Attachments
patch (10.21 KB, patch)
2017-11-09 05:19 UTC, Yuri Victorovich 		no flags Details | Diff
poudriere log (171.96 KB, text/x-log)
2017-12-02 17:09 UTC, Henry Hu 		no flags Details
patch (10.31 KB, patch)
2017-12-03 02:02 UTC, Yuri Victorovich 		yuri: maintainer-approval?
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-11-09 00:54:45 UTC 
Thanks!

Yuri
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-09 01:44:22 UTC 
misc/unicode-emoji: https://reviews.freebsd.org/D13011
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-09 02:42:33 UTC 
misc/cldr-emoji-annotation: https://reviews.freebsd.org/D13013
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-09 05:19:56 UTC 
Created attachment 187873 [details]
patch
Comment 4 Henry Hu 2017-12-02 17:09:09 UTC 
Created attachment 188472 [details]
poudriere log

Here is the poudriere log.

We should not depend on fontconfig and freetype. ibus does not use them directly. If you disable all the options, they are not required. They are introduced by other dependencies.

We do not need to depend on dbus, because we already depend on dbus-glib.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-03 02:02:03 UTC 
Created attachment 188483 [details]
patch

Henry,

You are right. Dependency were too broad. I narrowed them to options.


Yuri
Comment 6 Henry Hu 2017-12-03 03:58:21 UTC 
Why do you want to depend on freetype/fontconfig? ibus only uses them through gtk libraries. You cannot find anything like '#include <fontconfig.h>' or '#include <freetype/freetype.h>' in the source code. Besides, gtk2 already depends on them (through pango).
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-03 04:01:42 UTC 
(In reply to Henry Hu from comment #6)

> Why do you want to depend on freetype/fontconfig? ibus only uses them through gtk libraries.

When those LIB_DEPENDS are commented out, stage-qa shows that they are missing. This means that ibus executables actually link to them. In such case, it is required that LIB_DEPENDS have such dependencies.
Comment 8 Henry Hu 2017-12-03 04:09:32 UTC 
(In reply to Yuri Victorovich from comment #7)

Alright, although I think that those are leaked from other libraries. We can just leave them there to silence stage-qa.

Please commit it, after fixing the indentation problem of the first dependency of dbus.
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-03 19:23:20 UTC 
Committed, thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2017-12-03 19:23:48 UTC 
A commit references this bug:

Author: yuri
Date: Sun Dec  3 19:23:13 UTC 2017
New revision: 455422
URL: https://svnweb.freebsd.org/changeset/ports/455422

Log:
  textproc/ibus: Update to 1.5.17

  PR:		223549
  Submitted by:	yuri
  Approved by:	Henry Hu <henry.hu.sh@gmail.com> (maintainer), tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13354

Changes:
  head/textproc/ibus/Makefile
  head/textproc/ibus/distinfo
  head/textproc/ibus/pkg-plist