Bug 223876 - [PATCH] swapinfo/pstat -s alignment is broken with swap on zvols and long paths
Summary: [PATCH] swapinfo/pstat -s alignment is broken with swap on zvols and long paths
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-11-26 04:51 UTC by Laurent Cimon
Modified: 2017-11-26 04:51 UTC (History)
0 users

See Also:


Attachments
mentioned diff (1.58 KB, patch)
2017-11-26 04:51 UTC, Laurent Cimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Cimon 2017-11-26 04:51:50 UTC
Created attachment 188289 [details]
mentioned diff

Hi,

After using pstat(8) to see what my zvol swap looked like, the output was like this:

Device          1K-blocks     Used    Avail Capacity
/dev/zvol/rpool/swap   8388608        0  8388608     0%
/dev/md99            4000        0     4000     0%
Total             8392608        0  8392608     0%

I was a bit annoyed. I decided to simply align them to a total of 72 chars.
I think it's plenty for file names, and it made the output closer to what I expected.

Device                  1K-blocks         Used        Avail     Capacity
/dev/zvol/rpool/swap      8388608            0      8388608           0%
/dev/md99                    4000            0         4000           0%
Total                     8392608            0      8392608           0%

It might not be the most flexible solution, but I personally think it's plenty,
as filenames directing to swap usually wouldn't be much longer than this.

Attached is a proposed diff. I also took the liberty of fixing a few style bugs.
Namely, static flags being explicitly initialized to 0 while others weren't,
although they were all tested, and a flag being set to 1 with ++var instead
of using var = 1 as with all the others.

Good day.