Bug 223972 - net/asterisk-chan_sccp: Update to 4.3.1
Summary: net/asterisk-chan_sccp: Update to 4.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-11-29 16:54 UTC by Diederik de Groot
Modified: 2019-02-20 08:33 UTC (History)
1 user (show)

See Also:


Attachments
Patch for net/asterisk-chan_sccp port package (2.96 KB, patch)
2017-11-29 16:54 UTC, Diederik de Groot
no flags Details | Diff
Updated patch file (2.83 KB, patch)
2018-09-20 00:35 UTC, Diederik de Groot
no flags Details | Diff
Updated patch file (2.80 KB, patch)
2018-09-20 00:37 UTC, Diederik de Groot
no flags Details | Diff
Updated patch file v3 (2.80 KB, patch)
2018-09-20 00:53 UTC, Diederik de Groot
no flags Details | Diff
Updated patch file v4 (3.37 KB, patch)
2019-02-19 21:17 UTC, Diederik de Groot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diederik de Groot 2017-11-29 16:54:31 UTC
Created attachment 188404 [details]
Patch for net/asterisk-chan_sccp port package

The version is bumped to v4.3.1.
The chan-sccp project moved from sourceforge to github a while back.
Extra usage/conf example files are included in the built package.
Comment 1 Diederik de Groot 2017-12-13 01:11:15 UTC
Is there something i can do to expedite this patch ?
Comment 2 Diederik de Groot 2018-09-20 00:35:32 UTC
Created attachment 197252 [details]
Updated patch file
Comment 3 Diederik de Groot 2018-09-20 00:37:26 UTC
Created attachment 197253 [details]
Updated patch file

Changes requested by ndowens
Added support for asterisk 13 and 15
Comment 4 Nathan 2018-09-20 00:50:26 UTC
Comment on attachment 197253 [details]
Updated patch file

Builds fine on armv6 and no LLD6 issue on i386
Comment 5 Diederik de Groot 2018-09-20 00:53:23 UTC
Created attachment 197254 [details]
Updated patch file v3

Fixed sccp.conf.annotated instead of sccp.conf.*
Removed compiler from USES
Comment 6 Tobias Kortkamp freebsd_committer 2019-02-07 18:46:52 UTC
Comment on attachment 197254 [details]
Updated patch file v3

The port no longer seems to package anything.  There is no pkg-plist file and
PLIST_FILES is no longer there.  Is something missing from the patch?
Comment 7 Tobias Kortkamp freebsd_committer 2019-02-07 18:54:42 UTC
It also seems to fail configure:

===>  Configuring for asterisk-chan_sccp-4.3.1
autoconf/extra.m4:241: warning: macro 'AM_ICONV' not found in library
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'autoconf'.
libtoolize: copying file 'autoconf/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'autoconf'.
libtoolize: copying file 'autoconf/libtool.m4'
libtoolize: copying file 'autoconf/ltoptions.m4'
libtoolize: copying file 'autoconf/ltsugar.m4'
libtoolize: copying file 'autoconf/ltversion.m4'
libtoolize: copying file 'autoconf/lt~obsolete.m4'
libtoolize: Remember to add 'LT_INIT' to configure.ac.
autoconf/extra.m4:241: warning: macro 'AM_ICONV' not found in library
configure:22396: error: possibly undefined macro: AM_ICONV
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf-2.69: /usr/local/bin/autoconf-2.69 failed with exit status: 1
*** Error code 1
Comment 8 Diederik de Groot 2019-02-07 19:49:25 UTC
@Tobias Kortkamp You need the iconv dependency (which is listed as dependency) installed to be able to build correctly. The iconv dependency should also include the AM_ICONV m4 macro AFAIK. I will have to fire up a FreeBSD machine to check. I will try to do this tomorrow. I guess the patch would have to be updated anyway, to include new changes and building against asterisk-16 (instead of 15).

General Comment: It's a bit annoying to have to wait for over a year to get any kind of response. Zero progress so far.
Comment 9 Diederik de Groot 2019-02-19 21:17:16 UTC
Created attachment 202170 [details]
Updated patch file v4

Fix issue raised by 'Tobias Kortkamp'
Add support for asterisk-16
Update chan-sccp version
Comment 10 Diederik de Groot 2019-02-19 21:18:36 UTC
(In reply to Tobias Kortkamp from comment #7)
Hi Tobias,
I upgraded my freebsd version and fixed the previous chan-sccp patch. If you like you can give the new version a try, please.
Comment 11 Tobias Kortkamp freebsd_committer 2019-02-20 08:32:41 UTC
The AM_ICONV error still happened.  I've removed USES=autoreconf
as there appears to be a usable and pregenerated configure script
in the tarball already and it built fine with it.

I've also installed sccp.conf with @sample as it appears to be
something that is supposed to be user editable.
Comment 12 commit-hook freebsd_committer 2019-02-20 08:33:15 UTC
A commit references this bug:

Author: tobik
Date: Wed Feb 20 08:32:35 UTC 2019
New revision: 493415
URL: https://svnweb.freebsd.org/changeset/ports/493415

Log:
  net/asterisk-chan_sccp: Update to 4.3.2

  - Make conference and video support optional (enabled by default)
  - Add options to select different Asterisk versions
  - Build for net/asterisk16 by default

  While here

  - Install sccp.conf with @sample
  - Run it through portfmt once, fix indentation
  - Reorder variables according to chapter 15 of the PHB
  - Pet portlint

  PR:		223972
  Submitted by:	maintainer

Changes:
  head/net/asterisk-chan_sccp/Makefile
  head/net/asterisk-chan_sccp/distinfo