Bug 223991 - Typos in sbin/decryptcore/decryptcore.8
Summary: Typos in sbin/decryptcore/decryptcore.8
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Konrad Witaszczyk
Keywords: patch
Depends on:
Reported: 2017-11-30 13:26 UTC by Trond.Endrestol
Modified: 2018-01-29 09:23 UTC (History)
2 users (show)

See Also:

Patch for sbin/decryptcore/decryptcore.8 (1.06 KB, patch)
2017-11-30 13:26 UTC, Trond.Endrestol
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond.Endrestol 2017-11-30 13:26:47 UTC
Created attachment 188425 [details]
Patch for sbin/decryptcore/decryptcore.8

I suggest using dumpno instead of dumpnr. The misspelling of encryptedcore should be obvious.
Comment 1 Konrad Witaszczyk freebsd_committer 2017-12-01 09:58:57 UTC
Of course I agree with the misspelling of encryptedcore.

Could you explain why would you prefer dumpno? dumpnr was used to make it consistent with kgdb(1) and crashinfo(8). I'd rather not change it without good reasons. FYI dumpno change would also require a change in sbin/decryptcore/decryptcore.c in usage().
Comment 2 Trond.Endrestol 2017-12-01 10:21:36 UTC
(In reply to Konrad Witaszczyk from comment #1)
If "nr" is supposed to signify "number", then the abbreviation "no" for the Latin word "numero" is preferred in English. If you and/or the others disagree, then ignore this part of the patch.
Comment 3 Conrad Meyer freebsd_committer 2017-12-01 18:01:21 UTC
(In reply to Trond.Endrestol from comment #2)
I don't believe there's any reason to prescribe "no" instead of "nr".
Comment 4 commit-hook freebsd_committer 2018-01-29 09:22:07 UTC
A commit references this bug:

Author: def
Date: Mon Jan 29 09:21:08 UTC 2018
New revision: 328535
URL: https://svnweb.freebsd.org/changeset/base/328535

  Fix misspelling of encryptedcore.

  PR:		223991
  Submitted by:	Trond Endrestol <Trond.Endrestol@ximalas.info>
  Approved by:	pjd (mentor)

Comment 5 Konrad Witaszczyk freebsd_committer 2018-01-29 09:23:45 UTC
The misspelling was fixed in r328535. Thanks for reporting the issue!