Bug 224005 - DOCS_DISTFILES doesn't work with DISTNAME: it overwrites DISTFILES instead of adding to it when DISTNAME is present
Summary: DOCS_DISTFILES doesn't work with DISTNAME: it overwrites DISTFILES instead of...
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-30 21:50 UTC by Yuri Victorovich
Modified: 2017-12-01 07:57 UTC (History)
1 user (show)

See Also:

Attachments
testcase port patch (4.39 KB, patch)
2017-11-30 21:50 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-11-30 21:50:13 UTC 
Created attachment 188436 [details]
testcase port patch

In the attached port, please observe how only docs distfile is set when DOCS=on.
Replacing DISTNAME line with DISTFILES line enables the source distfile.

This is wrong because the option helper DOCS_DISTFILES shouldn't erase the previously set values.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2017-11-30 21:52:19 UTC 
I believe this was already discussed several times and this behavior is intented.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-30 21:54:19 UTC 
This is very confusing, why is this intended?
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2017-12-01 07:54:26 UTC 
Because DISTFILES is set after options processing, and is never overwritten.

I'll add DISTFILES to the warning in https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#options-variables
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-12-01 07:57:03 UTC 
A commit references this bug:

Author: mat
Date: Fri Dec  1 07:56:26 UTC 2017
New revision: 51245
URL: https://svnweb.freebsd.org/changeset/doc/51245

Log:
  Add DISTFILES to the warning.

  PR:		224005
  Reported by:	yuri
  Sponsored by:	Absolight

Changes:
  head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml