Bug 224034 - www/palemoon: sndio: improve and clamp float->s16 conversion
Summary: www/palemoon: sndio: improve and clamp float->s16 conversion
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
Keywords: patch
Depends on:
Reported: 2017-12-02 10:25 UTC by Tobias Kortkamp
Modified: 2017-12-03 07:19 UTC (History)
1 user (show)

See Also:

palemoon.diff (1.90 KB, patch)
2017-12-02 10:25 UTC, Tobias Kortkamp
lichray: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2017-12-02 10:25:38 UTC
Created attachment 188468 [details]


when Pale Moon (compiled with SNDIO=on) tries to playback files with
float samples then something is very wrong and we can hear some
annoying sound crackling / distortion.  For example this can be heard
when playing this video [1].

To fix it we need to backport one more patch for the sndio backend
that improves the float->s16 conversion function.


[1] https://www.youtube.com/watch?v=iJxM-YNc4oE
Comment 1 lichray 2017-12-03 04:46:19 UTC
Comment on attachment 188468 [details]

Comment 2 commit-hook freebsd_committer 2017-12-03 07:17:29 UTC
A commit references this bug:

Author: tobik
Date: Sun Dec  3 07:17:18 UTC 2017
New revision: 455391
URL: https://svnweb.freebsd.org/changeset/ports/455391

  www/palemoon: sndio: improve and clamp float->s16 conversion

  This fixes sound glitches/crackling when playing audio or video clips
  with float samples with SNDIO=on.

  PR:		224034
  Submitted by:	lichray@gmail.com (maintainer)
  Obtained from:	cubeb

Comment 3 Tobias Kortkamp freebsd_committer 2017-12-03 07:19:31 UTC
Committed. Thanks!