Bug 224041 - irc/inspircd: Modernize port
Summary: irc/inspircd: Modernize port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://reviews.freebsd.org/D13345
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-02 20:22 UTC by Dmitri Goutnik
Modified: 2017-12-19 02:29 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (feld)

Attachments
patch file (26.16 KB, patch)
2017-12-02 20:22 UTC, Dmitri Goutnik 		dmgk: maintainer-approval+
Details | Diff
patch file (25.94 KB, patch)
2017-12-04 13:55 UTC, Dmitri Goutnik 		dmgk: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2017-12-02 20:22:35 UTC 
Created attachment 188475 [details]
patch file

* Switch to option helpers
* Change module installation path to ${PREFIX}/libexec
* Add IPV6 knob
* Add pkg-deinstall with reminder to remove orphaned dirs and user/group
* Add LICENSE_FILE
* While here, switch to DISTVERSION

QA:
  portlint -AC: OK
  poudriere testport: OK (11a, 10i)
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2017-12-04 13:55:06 UTC 
Created attachment 188522 [details]
patch file

Address https://reviews.freebsd.org/D13345 feedback.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-18 21:46:53 UTC 
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-12-18 21:47:20 UTC 
A commit references this bug:

Author: yuri
Date: Mon Dec 18 21:46:46 UTC 2017
New revision: 456675
URL: https://svnweb.freebsd.org/changeset/ports/456675

Log:
  irc/inspircd: Modernize port

  PR:		224041
  Submitted by:	Dmitri Goutnik <dg@syrec.org> (maintainer)
  Approved by:	adamw (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13345

Changes:
  head/irc/inspircd/Makefile
  head/irc/inspircd/files/inspircd.in
  head/irc/inspircd/pkg-plist
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-12-19 02:29:22 UTC 
A commit references this bug:

Author: yuri
Date: Tue Dec 19 02:29:04 UTC 2017
New revision: 456702
URL: https://svnweb.freebsd.org/changeset/ports/456702

Log:
  irc/inspircd: Modernize port (adding files/pkg-deinstall.in)

  Addition to r456675: the new file files/pkg-deinstall.in has
  been approved, but hasn't been added in r456675.

  PR:		224041
  Submitted by:	Dmitri Goutnik <dg@syrec.org> (maintainer)
  Approved by:	adamw (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13345

Changes:
  head/irc/inspircd/files/pkg-deinstall.in