Bug 224048 - freebsd-update should check for src component under BASEDIR
Summary: freebsd-update should check for src component under BASEDIR
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-03 07:12 UTC by Michael Zuo
Modified: 2019-03-05 18:55 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zuo 2017-12-03 07:12:12 UTC
freebsd-update checks in config_Components whether /usr/src/COPYRIGHT exists, and if it doesn't, avoids avoids adding src to the components list even if it is listed in the configuration file.

When run with -b, the src component may be installed in the system at basedir, but not outside. In this case, freebsd-update nonetheless *does not* include the src component, which it should.
Comment 1 commit-hook freebsd_committer 2019-01-18 17:42:40 UTC
A commit references this bug:

Author: emaste
Date: Fri Jan 18 17:41:45 UTC 2019
New revision: 343152
URL: https://svnweb.freebsd.org/changeset/base/343152

Log:
  freebsd-update: Use BASEDIR when checking for src component

  src could potentially be installed under the based dir
  and not under the root or vice versa.

  PR:		224048
  Submitted by:	Gerald Aryeetey <aryeeteygerald_rogers.com>
  Reviewed by:	delphij
  MFC after:	1 month
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D18849

Changes:
  head/usr.sbin/freebsd-update/freebsd-update.sh
Comment 2 commit-hook freebsd_committer 2019-03-05 18:52:19 UTC
A commit references this bug:

Author: emaste
Date: Tue Mar  5 18:52:14 UTC 2019
New revision: 344811
URL: https://svnweb.freebsd.org/changeset/base/344811

Log:
  MFC r343152: freebsd-update: Use BASEDIR when checking for src component

  src could potentially be installed under the based dir
  and not under the root or vice versa.

  PR:		224048
  Submitted by:	Gerald Aryeetey <aryeeteygerald_rogers.com>
  Reviewed by:	delphij
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/12/
  stable/12/usr.sbin/freebsd-update/freebsd-update.sh
Comment 3 commit-hook freebsd_committer 2019-03-05 18:55:27 UTC
A commit references this bug:

Author: emaste
Date: Tue Mar  5 18:54:47 UTC 2019
New revision: 344813
URL: https://svnweb.freebsd.org/changeset/base/344813

Log:
  freebsd-update: Use BASEDIR when checking for src componentfreebsd-update: Use BMFC r343152: freebsd-update: Use BASEDIR when checking for src component

  src could potentially be installed under the based dir
  and not under the root or vice versa.

  PR:		224048
  Submitted by:	Gerald Aryeetey <aryeeteygerald_rogers.com>
  Reviewed by:	delphij
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/11/
  stable/11/usr.sbin/freebsd-update/freebsd-update.sh