Bug 224068 - www/py-pyocclient: bump to version 0.4 (patch)
Summary: www/py-pyocclient: bump to version 0.4 (patch)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-03 23:06 UTC by Alexandre C. Guimarães
Modified: 2017-12-21 16:07 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (che)

Attachments
Update to 0.4. (1.30 KB, patch)
2017-12-03 23:06 UTC, Alexandre C. Guimarães 		no flags Details | Diff
pyocclient.diff (2.29 KB, patch)
2017-12-04 15:50 UTC, Tobias Kortkamp 		no flags Details | Diff
Fixing. (1.27 KB, patch)
2017-12-04 17:09 UTC, Alexandre C. Guimarães 		no flags Details | Diff
The actual the fix. (2.47 KB, patch)
2017-12-04 17:16 UTC, Alexandre C. Guimarães 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-12-03 23:06:27 UTC 
Created attachment 188506 [details]
Update to 0.4.

The provided patch does:

* update to version 0.4;
* add new dependency
* add "noflavors" to USE_PYTHON. The is python:2.7 only.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-12-04 14:35:12 UTC 
(In reply to Le Baron d'Merde from comment #0)
> * add "noflavors" to USE_PYTHON. The is python:2.7 only.

Are you sure about that? https://github.com/owncloud/pyocclient/ says it also
supports Python >= 3.5.
Comment 2 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-12-04 15:27:29 UTC 
That fail to build with anything python:3.

>>>>>>>>>>>>
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 18, in <module>
    + '\n')
  File "/usr/local/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 229: ordinal not in range(128)
*** Error code 1
<<<<<<<<<<<<

I do not know python, but its setup.py says:

'Development Status :: 3 - Alpha'

what I suppose the python:3+ status is still in alpha. Doesn't it?

Thanks!
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2017-12-04 15:50:09 UTC 
Created attachment 188524 [details]
pyocclient.diff

(In reply to Le Baron d'Merde from comment #2)
This fixes the build for all flavors (py27, py36).

I'm not sure if it works at runtime though.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2017-12-04 15:54:01 UTC 
(In reply to Tobias Kortkamp from comment #3)
Oh, looks like upstream already fixed it in the same way:
https://github.com/owncloud/pyocclient/commit/aa6b4374a779bf0f9e060117b2e8d1e810342bc8#diff-2eeaed663bd0d25b7e608891384b7298
Comment 5 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-12-04 17:09:34 UTC 
Created attachment 188527 [details]
Fixing.

I got the upstream patch.

I could not find the way to restrict it to build all python FLAVORS but python:3.4!

Thanks!
Comment 6 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-12-04 17:16:51 UTC 
Created attachment 188528 [details]
The actual the fix.

I forgot I had to add the file to svn. :)

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-12-21 16:07:42 UTC 
A commit references this bug:

Author: tobik
Date: Thu Dec 21 16:07:08 UTC 2017
New revision: 456914
URL: https://svnweb.freebsd.org/changeset/ports/456914

Log:
  www/py-pyocclient: Update to 0.4

  - Allow build for Python 3.x

  PR:		224068
  Submitted by:	lbdm@privacychain.ch
  Approved by:	che@bein.link (maintainer timeout, 2 weeks)

Changes:
  head/www/py-pyocclient/Makefile
  head/www/py-pyocclient/distinfo
  head/www/py-pyocclient/files/
  head/www/py-pyocclient/files/patch-setup.py