Bug 224090 - databases/mongodb34: fails to build with boost 1.66
Summary: databases/mongodb34: fails to build with boost 1.66
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
Keywords: needs-patch
Depends on:
Blocks: 223922
  Show dependency treegraph
Reported: 2017-12-04 17:57 UTC by Jan Beich
Modified: 2018-02-02 09:56 UTC (History)
3 users (show)

See Also:

Fixes the build with boost 1.66 (1.21 KB, patch)
2018-01-23 10:07 UTC, Aleksejs Sinicins
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-12-04 17:57:23 UTC
As part of exp-run in bug 223922 this port was found to break on Boost update. If the issue won't disappear on its own by Boost release I plan to mark the port as BROKEN. Can you check with upstream maintainer or help with a fix?

$ fetch -qo- 'https://reviews.freebsd.org/D13279?download=true' | patch -Efsp0 -d /usr/ports
$ make all deinstall install clean -C/usr/ports/devel/boost-libs
$ make -C/usr/ports/comms/usrp
src/mongo/db/repl/oplog_fetcher.cpp:268:22: error: no matching function for call to 'make_optional'
        oqMetadata = boost::make_optional<rpc::OplogQueryMetadata>(metadataResult.getValue());
/usr/local/include/boost/optional/optional.hpp:1367:56: note: candidate function not viable: no known conversion from 'mongo::rpc::OplogQueryMetadata' to 'mongo::rpc::OplogQueryMetadata &&' for 1st argument
optional<BOOST_DEDUCED_TYPENAME boost::decay<T>::type> make_optional ( T && v  )
/usr/local/include/boost/optional/optional.hpp:1375:56: note: candidate function template not viable: requires 2 arguments, but 1 was provided
optional<BOOST_DEDUCED_TYPENAME boost::decay<T>::type> make_optional ( bool cond, T && v )

Comment 1 Jan Beich freebsd_committer 2017-12-04 18:00:36 UTC
(In reply to Jan Beich from comment #0)
> $ make -C/usr/ports/comms/usrp

Sorry, like with i386 logs I forgot to adjust template for databases/mongodb34. Other details are still correct though.
Comment 2 Aleksejs Sinicins 2018-01-23 10:07:18 UTC
Created attachment 189989 [details]
Fixes the build with boost 1.66
Comment 3 commit-hook freebsd_committer 2018-01-28 02:46:26 UTC
A commit references this bug:

Author: jbeich
Date: Sun Jan 28 02:45:33 UTC 2018
New revision: 460156
URL: https://svnweb.freebsd.org/changeset/ports/460156

  databases/mongodb34{,-rocks}: unbreak with boost 1.66

  PR:		224090 224091
  Approved by:	maintainer timeout (1 month)

Comment 4 commit-hook freebsd_committer 2018-02-02 09:56:43 UTC
A commit references this bug:

Author: jbeich
Date: Fri Feb  2 09:55:52 UTC 2018
New revision: 460686
URL: https://svnweb.freebsd.org/changeset/ports/460686

  databases/mongodb34{,-rocks}: switch to upstream Boost 1.66 fix

  PR:		224090 224091