Bug 224095 - www/waterfox mentions of firefox in waterfox.desktop
Summary: www/waterfox mentions of firefox in waterfox.desktop
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-04 20:27 UTC by Graham Perrin
Modified: 2017-12-08 02:43 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2017-12-04 20:27:29 UTC 
/usr/local/share/applications/waterfox.desktop
contained a few mentions of firefox/Firefox. I manually edited the file to include: 

Name=Waterfox web browser

Exec=waterfox %U
Icon=waterfox
Exec=waterfox -new-window
Exec=waterfox -private-window

(Things seem to be fine, with those changes, touch wood.)
Comment 1 Jan Beich freebsd_committer freebsd_triage 2017-12-08 01:59:04 UTC 
(Not sure why auto-assigner didn't notify me.)

Waterfox is using Firefox desktop file due to lack of a better source. Currently, it replaces some "Firefox" with "Waterfox". It seems I forgot to adjust executable/icon name via post-patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-12-08 02:42:38 UTC 
A commit references this bug:

Author: jbeich
Date: Fri Dec  8 02:41:30 UTC 2017
New revision: 455766
URL: https://svnweb.freebsd.org/changeset/ports/455766

Log:
  www/waterfox: fix exec/icon name in .desktop file

  PR:		224095
  Reported by:	Graham Perrin

Changes:
  head/www/waterfox/Makefile