Created attachment 188540 [details]
svnlite diff to increase version to 0.22.1 _and_ re-enabling setuid on several helper binaries...
some of the pkg-plist changes cannot possibly be correct:
freebsd12.0-amd64-0.22 should be replaced with %%ENLIGHTENMENT_ARCH%%.
It's defined in Makefile.plist for some reason which probably needs an
All locale files will have to be prefixed with %%NLS%% (otherwise the
NLS option will be broken).
Once PORTEPOCH is bumped it can never be reset to a lower value.
"pkg-plist" is corrected now. Thank you very much for the explainations. Makes absolute sense to me now and the resulting diff much smaller. I trusted into "make makeplist" too much.
Regarding "PORTEPOCH" - I don't understand your objection. Why should PORTEPOCH ever be lower than "0" (zero)? Isn't it sensible to reset PORTEPOCH to zero whenever PORTVERSION increases?
Created attachment 188545 [details]
[patch] svnlite diff to increase version to 0.22.1 _and_ re-enabling setuid on several helper binaries... (fixed pkg-plist)
(In reply to Nils Beyer from comment #2)
> Regarding "PORTEPOCH" - I don't understand your objection. Why should
> PORTEPOCH ever be lower than "0" (zero)? Isn't it sensible to reset PORTEPOCH
> to zero whenever PORTVERSION increases?
No, you can reset PORTREVISION but never decrease or reset PORTEPOCH.
It's increase-only. See https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portepoch
Created attachment 188547 [details]
188545: [patch] svnlite diff to increase version to 0.22.1 _and_ re-enabling setuid on several helper binaries... (fixed pkg-plist and PORTEPOCH)
(In reply to Nils Beyer from comment #5)
Created attachment 188578 [details]
*sigh* "-ver-"-interfix needs to be removed...
We chose to remove the setuid bits for a reason. so please remove them. As per the message users can add them if they require them. Also please setup a test bed using poudriere so you don't end up submitting 3838383 patches.
A commit references this bug:
Date: Mon Jul 9 19:13:44 UTC 2018
New revision: 474282
- Update to 1.20.0
- Update to 0.3.0
- Switch to meson
- Update to 1.2.1
- Switch to meson
- Update to 0.22.3 
- Fix typo in pkg-message 
PR: 224105 , 226569 
Submitted by: Nils Beyer , Chris Petrik 
Committed with update to 0.22.3. Thanks.