Bug 224158 - PORTS_FEATURES contains the term FLAVORS many times
Summary: PORTS_FEATURES contains the term FLAVORS many times
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-07 05:04 UTC by Yuri Victorovich
Modified: 2019-09-05 13:47 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2017-12-07 05:04:46 UTC
It sometimes contains the term FLAVORS two or three times:

> $ cd /usr/ports/net-im/qTox && make -V PORTS_FEATURES
> FLAVORS FLAVORS
> $ cd /usr/ports/net-p2p/zetacoin && make -V PORTS_FEATURES
> FLAVORS FLAVORS FLAVORS
Comment 1 Mathieu Arnold freebsd_committer 2017-12-07 09:43:16 UTC
And this is a problem because ?
Comment 2 Yuri Victorovich freebsd_committer 2017-12-07 16:28:20 UTC
(In reply to Mathieu Arnold from comment #1)

I am not saying that this is a big problem, but once this happens this begs the question what does this mean? Is this a bug, or does it mean something? I think people will ask this question once they see it.
Comment 3 Mathieu Arnold freebsd_committer 2017-12-08 18:42:41 UTC
It happens when ports .include b.p.options.m or b.p.pre.m, because the code at the beginning of b.p.m is not guarded at all.
I don't feel that this is really a problem, and fixing it would possibly break some things.
I'll leave this open if someone wants to fix it.
Comment 4 commit-hook freebsd_committer 2019-09-05 13:46:00 UTC
A commit references this bug:

Author: bapt
Date: Thu Sep  5 13:45:38 UTC 2019
New revision: 511188
URL: https://svnweb.freebsd.org/changeset/ports/511188

Log:
  Avoid appending FLAVORS to PORTS_FEATURES multiple times

  PR:		224158
  Reported by:	yuri@

Changes:
  head/Mk/bsd.port.mk