Bug 224202 - [PATCH] x11-toolkits/wlc: Update to 0.0.10
Summary: [PATCH] x11-toolkits/wlc: Update to 0.0.10
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
Keywords: patch
Depends on: 227423
  Show dependency treegraph
Reported: 2017-12-09 14:24 UTC by Johannes Lundberg
Modified: 2018-10-28 18:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Patch to update x11-toolkits/wlc to 0.0.10 (9.16 KB, patch)
2017-12-09 14:24 UTC, Johannes Lundberg
no flags Details | Diff
Log of failed build (30.33 KB, text/x-log)
2017-12-09 21:13 UTC, Niclas Zeising
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Lundberg 2017-12-09 14:24:04 UTC
Created attachment 188648 [details]
Patch to update x11-toolkits/wlc to 0.0.10

Update to 0.0.10. FreeBSD patches has been upstreamed so no need patch files in ports anymore.
Comment 1 Niclas Zeising freebsd_committer 2017-12-09 16:39:14 UTC
Working on this.
Comment 2 Niclas Zeising freebsd_committer 2017-12-09 21:07:33 UTC
I get a build failure when test building this in poudriere, both on amd64 and i386.  The last bit of the error message is:

-- The following REQUIRED packages have not been found:

 * Wayland, Protocol for implementing compositors, <http://wayland.freedesktop.org/>

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
    linked by target "wlc-tests" in directory /wrkdirs/usr/ports/x11-toolkits/wlc/work/wlc-0.0.10/src
    linked by target "wlc" in directory /wrkdirs/usr/ports/x11-toolkits/wlc/work/wlc-0.0.10/src

-- Configuring incomplete, errors occurred!
See also "/wrkdirs/usr/ports/x11-toolkits/wlc/work/wlc-0.0.10/CMakeFiles/CMakeOutput.log".
*** Error code 1

make: stopped in /usr/ports/x11-toolkits/wlc

I'll attach a complete log in a moment, but it seems like there are some dependency missing (or cmake at least fails to find it).
Comment 3 Niclas Zeising freebsd_committer 2017-12-09 21:13:00 UTC
Created attachment 188670 [details]
Log of failed build

Build log of failed build.
Comment 4 Johannes Lundberg 2017-12-09 21:25:55 UTC
It needs mesa-libs built with wayland=on. If we won't make it default, we need flavors for it.
Comment 5 Niclas Zeising freebsd_committer 2017-12-09 21:34:10 UTC
That explains.  I'll put this on hold for a little while then, until I can test with wayland on in mesa stuff.  I think flavours or sub-packages for mesa-libs is a while off, although this sounds like a candidate for it.
Comment 6 Greg V 2017-12-10 11:34:18 UTC
(In reply to Johannes Lundberg from comment #4)
Maybe add libwayland-egl.so:graphics/mesa-libs to LIB_DEPENDS to detect this earlier?

IIRC we've had separate libGL libEGL … packages before, that was awful. If ports had a sub-packages feature that actually created multiple packages from one port build, that would be great. Like Arch Linux: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/mesa — one build (mesa), many packages (Vulkan, OpenCL, VAAPI, VDPAU, the rest)

But for now, "build all the things" is the better option. And it's actually what's happening mostly — GLESv2 is always built, EGL is ~always built (when LLVM is available). Only the tiny 4.5kb libwayland-egl.so is optional. (Okay, it depends on the wayland package, so adds a bit more than 4.5kb, but whatever)
Comment 7 Johannes Lundberg 2017-12-10 14:27:45 UTC
> Maybe add libwayland-egl.so:graphics/mesa-libs to LIB_DEPENDS to detect this earlier?

Yes, I agree. Will add this. 

I also agree we should set wayland=on as default on all related ports. It adds so little in package sizes but enables so much... Not to mention, Wayland-based compositors will be the default window servers instead of X11 soon enough so there's no reason not to. It's just a matter of time.
Comment 8 Jan Beich freebsd_committer 2018-10-28 18:51:32 UTC
While libwayland-egl no longer being tied by WAYLAND option in mesa-libs allows the update to proceed this port is no longer useful.