Bug 224205 - net-mgmt/kapacitor: Update to 1.4.0
Summary: net-mgmt/kapacitor: Update to 1.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-09 16:02 UTC by cheffo
Modified: 2018-03-10 10:42 UTC (History)
1 user (show)

See Also:
cheffo: maintainer-feedback+


Attachments
Update kapacitor to 1.4.0 (7.90 KB, patch)
2017-12-09 16:02 UTC, cheffo
no flags Details | Diff
patch kapacitor to 1.4.0 (7.41 KB, patch)
2018-03-09 13:50 UTC, cheffo
cheffo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cheffo 2017-12-09 16:02:16 UTC
Created attachment 188653 [details]
Update kapacitor to 1.4.0

1) Update kapacitor to 1.4.0
2) Switch from root to influxd user as no root permissions are needed for the daemon
3) Update startup script to be more like influxdb startup script
4) Fix little default config file to be more FreeBSD Friendly
5) Add DB and LOG folders to plist

May be UPDATING entry is needed to specify that ownership of DB and LOG folders have to be changed manually as we are switching the default user?
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2017-12-20 10:51:45 UTC
take it
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2017-12-29 21:19:17 UTC
The patch you submit has some space issues, please do a portlint check [1] before re-submit it. 

Question : why use daemon as log command between FreeBSD 1100513 and 12 ?

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing-portlint.html
Comment 3 cheffo 2018-03-09 13:50:53 UTC
Created attachment 191337 [details]
patch kapacitor to 1.4.0

New patch with fixed whitespace issues.

To answer the question for logging - I'm just syncing with the influxdb port.
This change was introduced here - https://svnweb.freebsd.org/ports/head/databases/influxdb/Makefile?r1=449829&r2=449830&
https://svnweb.freebsd.org/ports/head/databases/influxdb/files/influxd.in?annotate=449830


whith the following comment:

Thu Sep 14 11:17:52 2017 UTC (5 months, 3 weeks ago) by eugen 
File MIME type: text/plain 
File size: 4813 byte(s)
Redirect all output to syslog by means of daemon(8) having syslog support
in recent FreeBSD versions and by means of piping it to logger(1)
for previous FreeBSD versions: add influxd_facility and influxd_priority
variables (defaults to daemon.info). Bump PORTREVISION.

PR:		221960
Submitted by:	Sascha Holzleiter
Approved by:	cheffo (maintainer)
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-10 10:42:06 UTC
A commit references this bug:

Author: rodrigo
Date: Sat Mar 10 10:41:37 UTC 2018
New revision: 464062
URL: https://svnweb.freebsd.org/changeset/ports/464062

Log:
  Update net-mgmt/kapacitor from 1.3.2 to 1.4.0

  Major changes :
      Load TICKscripts and alert handlers from a directory.
      Structed Logging with a logging API endpoints to be able to tail logs for given tasks.
      Autoscale support for Docker Swarm and EC2 Autoscaling.
      Sideload data into your TICKscript streams from external sources.
      Fully customizable POST body for the alert POST handler and the httpPost node.

  See the complete list of bug fixes and features at
  https://github.com/influxdata/kapacitor/blob/master/CHANGELOG.md

  PR:		224205
  Submitted by:	cheffo@freebsd-bg.org (maintainer)

Changes:
  head/net-mgmt/kapacitor/Makefile
  head/net-mgmt/kapacitor/distinfo
  head/net-mgmt/kapacitor/files/kapacitord.in
  head/net-mgmt/kapacitor/pkg-plist
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2018-03-10 10:42:32 UTC
Committed, thanks