Bug 224263 - [NEW PORT] misc/thefuck: Magnificent app which corrects your previous console command
Summary: [NEW PORT] misc/thefuck: Magnificent app which corrects your previous console...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL: https://reviews.freebsd.org/D13460
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-12 07:02 UTC by Guangyuan Yang
Modified: 2018-01-05 09:44 UTC (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.92 KB, patch)
2017-12-12 07:02 UTC, Guangyuan Yang 		no flags Details | Diff
Updated patch (2.90 KB, patch)
2017-12-12 21:28 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guangyuan Yang freebsd_committer freebsd_triage 2017-12-12 07:02:47 UTC 
Created attachment 188742 [details]
Proposed patch

thefuck is a magnificent app which corrects your previous console command.

URI:https://github.com/nvbn/thefuck/
PyPI: https://pypi.python.org/pypi/thefuck/

Skipped the TEST_DEPENDS and do-test for now, since the test suite is not currently in the PyPI releases. Will add the test section once test cases were added back in the release.

testport: OK (11.1-RELEASE amd64, 10.4-RELEASE i386)

It is my first new port, so any feedback would be more than welcome!
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2017-12-12 21:11:06 UTC 
Sorry, Yuri, I didn't notice this PR. ygy is a committer and this PR should be assigned to him.

p.s. ygy: Assign your PRs to yourself!
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-12 21:28:20 UTC 
Created attachment 188774 [details]
Updated patch

(In reply to Adam Weinberger from comment #1)

Sorry, I didn't notice this.
Attaching the updated patch anyway.
Comment 3 Guangyuan Yang freebsd_committer freebsd_triage 2017-12-13 02:09:27 UTC 
(In reply to Adam Weinberger from comment #1)

Whoops! Didn't notice that, sorry.

Thanks Yuri!
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2017-12-13 03:35:56 UTC 
(In reply to Yuri Victorovich from comment #2)

USE_PYTHON=concurrent makes no sense here. The port is already restricted to 3.4+. A DEV_WARNING should have been triggered for this.

The BUILD_DEPENDS -> RUN_DEPENDS part is necessary though.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-13 03:53:33 UTC 
(In reply to Adam Weinberger from comment #4)

3.4+ means 3.4, 3.5, 3.6, etc. You can build them with PYTHON_VERSION=N.N environment variable. They will conflict without USE_PYTHON=concurrent.
Comment 6 Adam Weinberger freebsd_committer freebsd_triage 2017-12-13 04:03:26 UTC 
(In reply to Yuri Victorovich from comment #5)

I think you're right, Yuri. I misread a ! in the DEV_WARNING patch. I think you're right, USE_PYTHON=concurrent is the right thing here.

Sorry about the confusion, and thanks for setting me straight!
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-12-13 04:10:52 UTC 
(In reply to Adam Weinberger from comment #6)

No problem!
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-01-05 09:27:10 UTC 
A commit references this bug:

Author: ygy
Date: Fri Jan  5 09:26:49 UTC 2018
New revision: 458123
URL: https://svnweb.freebsd.org/changeset/ports/458123

Log:
  - Add thefuck 3.25

  Thefuck is a magnificent app which corrects your previous console command.
  It tries to match a rule for the previous command, creates a new command
  using the matched rule and runs it. Thefuck comes with a lot of predefined
  rules, but you can create your own rules as well.

  WWW: https://github.com/nvbn/thefuck

  PR:		224263
  Approved by:	adamw
  Differential Revision:	https://reviews.freebsd.org/D13460

Changes:
  head/misc/Makefile
  head/misc/thefuck/
  head/misc/thefuck/Makefile
  head/misc/thefuck/distinfo
  head/misc/thefuck/pkg-descr