Bug 224377 - textproc/rubygem-nokogiri has missing dependency to libxml2
Summary: textproc/rubygem-nokogiri has missing dependency to libxml2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-16 09:31 UTC by Matthias Fechner
Modified: 2017-12-17 16:04 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ruby)


Attachments
Add libxml2 dep and bump revision (568 bytes, patch)
2017-12-16 09:31 UTC, Matthias Fechner
no flags Details | Diff
Increase revision of port (219 bytes, patch)
2017-12-17 09:02 UTC, Matthias Fechner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Fechner freebsd_committer 2017-12-16 09:31:05 UTC
Created attachment 188876 [details]
Add libxml2 dep and bump revision

These days a security update for libxml2 was released in the ports.
Using rubygem-nokogiri now triggers this warning:
WARNING: Nokogiri was built against LibXML version 2.9.4, but has dynamically loaded 2.9.7

This is maybe caused by a missing lib dependency in the Makefile and therefor the reversion was not increased.

What do you think about the attached patch?
Comment 1 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-12-16 13:23:52 UTC
It's already there.

% cd /usr/ports/textproc/rubygem-nokogiri/
% grep libxml2 Makefile
USE_GNOME=      libxml2 libxslt
% make build-depends-list | grep libxml2
/usr/ports/textproc/libxml2
% make run-depends-list | grep libxml2
/usr/ports/textproc/libxml2
Comment 2 Matthias Fechner freebsd_committer 2017-12-17 09:02:04 UTC
Created attachment 188910 [details]
Increase revision of port

Thanks for this, then for an unkown reason the revision was not increased.
I changed the patch to only increase the revision to make sure, nokogiri is build against correct libxml2.
Comment 3 commit-hook freebsd_committer 2017-12-17 15:56:17 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Dec 17 15:55:08 UTC 2017
New revision: 456556
URL: https://svnweb.freebsd.org/changeset/ports/456556

Log:
  Bump PORTREVISION for libxml2 update

  Nokogiri gives out warning when libxml2 version changed.

  WARNING: Nokogiri was built against LibXML version 2.9.4, but has dynamically loaded 2.9.7

  Bump PORTREVISION to rebuild with latest libxml2.

  PR:		224377
  Submitted by:	Matthias Fechner <idefix@fechner.net>

Changes:
  head/textproc/rubygem-nokogiri/Makefile
Comment 4 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-12-17 16:04:42 UTC
Committed. Thanks!