Bug 224424 - multimedia/libva: install to lib/dri instead of lib/va
Summary: multimedia/libva: install to lib/dri instead of lib/va
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-18 13:00 UTC by Greg V
Modified: 2017-12-18 21:30 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback+


Attachments
libva-dir.patch (2.36 KB, patch)
2017-12-18 13:00 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg V 2017-12-18 13:00:06 UTC
Created attachment 188928 [details]
libva-dir.patch

The default installation directory, $PREFIX/lib/dri, is also used by Mesa to install r600 and radeonsi VAAPI drivers. (Also there's just no reason to change the new default to the old default.)

Without this patch, Radeon users would need to run programs with an extra environment variable: `LIBVA_DRIVERS_PATH=/usr/local/lib/dri vainfo`. With this patch, just `vainfo` works.
Comment 1 Guido Falsi freebsd_committer 2017-12-18 14:48:05 UTC
Hi,

Thanks for reporting.

The patch changing the install location has been there long before I started maintaining this port so I did not touch it and, not having any amd graphics cards, I did not notice the issue.

The patch looks good and I agree with your analysis. I'll commit it after a little testing.
Comment 2 commit-hook freebsd_committer 2017-12-18 21:27:02 UTC
A commit references this bug:

Author: madpilot
Date: Mon Dec 18 21:25:58 UTC 2017
New revision: 456673
URL: https://svnweb.freebsd.org/changeset/ports/456673

Log:
  Make libva and it's drivers install modules in the standard location
  PREFIX/lib/dri.

  This is the same location where other ports(mesa) install drivers,
  so that everything works out of the box.

  PR:		224424
  Submitted by:	Greg V <greg@unrelenting.technology>

Changes:
  head/multimedia/libva/Makefile
  head/multimedia/libva-intel-driver/Makefile
  head/multimedia/libva-vdpau-driver/Makefile
Comment 3 Guido Falsi freebsd_committer 2017-12-18 21:30:49 UTC
Committed. Thanks!