Created attachment 189019 [details]
patch php to change split to explode
PHP7 deprecated split: http://php.net/manual/en/function.split.php
Has this been obtained from upstream, or if you made it yourself, have you submitted it upstream?
I made it myself and have not submitted upstreams.
Since the fix is only for nagios-3.5, I'm not sure they will take interest? There is no branch for 3.5 in their repo so I couldn't post a pull request, only a bug report: https://github.com/NagiosEnterprises/nagioscore/issues/467
I suggest adding this trivial patch in the FreeBSD repo for now.
OK to commit?
Here's the answer:
I'm not sure much will get done about this, Version 3.5 is pretty old now (more than 4 years since it was released), is there a reason why you're still using such an old version?
Nagios4 already runs on PHP7, there's nothing to be done to support it.
I think that is reasonable. I think we should commit the patch. Perhaps also deprecate the port altogether, since it is not supported upstreams?
We still have the port because I tried a few times to migrate my nagios 3 installations to nagios 4, and it never worked, it was always stuck in some strange loop, or crashed, or did not run any probe. Since then I migrated to icinga, so I do not think it is needed any more. (I know, those are my needs.)
Feel free to commit the patch.
Yeahm nagios is a bitch sometimes.
I'll commit the patch, and let's leave it at that for a while.
A commit references this bug:
Date: Tue Jan 23 22:54:04 UTC 2018
New revision: 459801
Help nagios cope with php-7
split has been replaced with explode