Bug 224529 - The talk protocol depends on struct osockaddr which should be kernel-only
Summary: The talk protocol depends on struct osockaddr which should be kernel-only
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2017-12-22 20:13 UTC by Brooks Davis
Modified: 2019-01-18 21:42 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2017-12-22 20:13:07 UTC
The talkd protocol defined in include/protocols/talkd.h uses the struct osockaddr definition from sys/socket.h.  It should define it's own type so struct osockaddr can be removed from non-kernel use.  The support for systems where sockaddr is the same as osockaddr in the talk program should also be removed since we don't need our tools to run on 4.3BSD.
Comment 1 Brooks Davis freebsd_committer freebsd_triage 2018-02-25 18:42:41 UTC
https://reviews.freebsd.org/D14505 contains a fix.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-18 21:30:49 UTC
A commit references this bug:

Author: brooks
Date: Fri Jan 18 21:30:07 UTC 2019
New revision: 343161
URL: https://svnweb.freebsd.org/changeset/base/343161

Log:
  Use a private definition of osockaddr rather then relying on type
  namespace polution in sys/socket.h.

  Also remove support for operation on 4.3BSD.

  PR:		224529
  Differential Revision:	https://reviews.freebsd.org/D14505

Changes:
  head/include/protocols/talkd.h
  head/libexec/talkd/talkd.c
  head/usr.bin/talk/invite.c
  head/usr.bin/talk/look_up.c
Comment 3 Brooks Davis freebsd_committer freebsd_triage 2019-01-18 21:42:31 UTC
No sense in MFCing this no-op change.