Bug 224607 - www/otter-browser: Update to 0.9.93
Summary: www/otter-browser: Update to 0.9.93
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (Team)
URL: https://github.com/OtterBrowser/otter...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-12-27 01:21 UTC by Dmitri Goutnik
Modified: 2017-12-30 22:03 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
patch file (2.84 KB, patch)
2017-12-27 01:21 UTC, Dmitri Goutnik
no flags Details | Diff
patch file (4.09 KB, patch)
2017-12-27 22:03 UTC, Dmitri Goutnik
dmgk: maintainer-approval? (kde)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2017-12-27 01:21:30 UTC
Created attachment 189124 [details]
patch file

* Update to 0.9.93
* Remove files/patch-git_8b5934 (merged upstream)
* Add USE_QT5=svg

QA:
  poudriere testport: OK (11a)
Comment 1 Tobias C. Berner freebsd_committer 2017-12-27 07:19:16 UTC
Thanks.

I think with this update we should also introduce WEBKIT and WEBENGINE options.
(I think they are nor exclusive), or if no options then at least explicitly disable the other so that it does not get built accidentally.


Mfg Tobias
Comment 2 Tobias C. Berner freebsd_committer 2017-12-27 07:24:51 UTC
From CMakeLists.txt

option(ENABLE_QTWEBENGINE "Enable QtWebEngine backend (requires Qt 5.6)" ON)
option(ENABLE_QTWEBKIT "Enable QtWebKit backend (requires Qt 5.4)" ON)

So I would suggest to ad an OPTIONS_MULTI ENGINE
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html

With CMAkE_BOOLs set to the Cmake options above

Mfg Tobias
Comment 3 Dmitri Goutnik freebsd_committer 2017-12-27 22:03:15 UTC
Created attachment 189140 [details]
patch file

Hi Tobias,

Thanks for the suggestion, I've updated the patch with OPTIONS_MULTI=BACKEND and added pkg-message with an explanation how to select newer QtWebEngine backend.

poudriere testport OK on 11a.
Comment 4 commit-hook freebsd_committer 2017-12-30 22:00:49 UTC
A commit references this bug:

Author: adridg
Date: Sat Dec 30 22:00:03 UTC 2017
New revision: 457644
URL: https://svnweb.freebsd.org/changeset/ports/457644

Log:
  Update www/otter-browser to latest released version.

  See https://github.com/OtterBrowser/otter-browser/releases/tag/v0.9.93 ,
  only minor changes since last month's upstream release, but FreeBSD
  is 10 months behind on otter releases.

  Default options build both WebKit and WebEngine, which is possibly
  a bit heavy.

  PR:		224607
  Submitted by:	Dmitri Goutnik
  Reported by:	Dmitri Goutnik
  Approved by:	tcberner (mentor)

Changes:
  head/www/otter-browser/Makefile
  head/www/otter-browser/distinfo
  head/www/otter-browser/files/
  head/www/otter-browser/pkg-message
Comment 5 Adriaan de Groot freebsd_committer 2017-12-30 22:03:36 UTC
Committed to ports. Thanks, Dmitri, for bringing otter back up-to-date!

The browser core dumps on exit; this is a known problem, see the github issues for otter. It happens with both backends.