Bug 224613 - Remove support for variables that have been deprecated for a while
Summary: Remove support for variables that have been deprecated for a while
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL: https://reviews.freebsd.org/D13490
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-27 13:20 UTC by Mathieu Arnold
Modified: 2018-01-09 07:41 UTC (History)
1 user (show)

See Also:
antoine: exp-run+


Attachments
v1 (10.90 KB, patch)
2017-12-27 13:20 UTC, Mathieu Arnold
no flags Details | Diff
v2 (12.73 KB, patch)
2017-12-27 13:52 UTC, Mathieu Arnold
no flags Details | Diff
v3 (13.44 KB, patch)
2017-12-27 16:43 UTC, Mathieu Arnold
no flags Details | Diff
v4 (44.18 KB, patch)
2017-12-28 12:15 UTC, Mathieu Arnold
no flags Details | Diff
v5 (91.08 KB, patch)
2018-01-04 15:13 UTC, Mathieu Arnold
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer 2017-12-27 13:20:14 UTC
Created attachment 189127 [details]
v1

I don't expect any fallout, but to be safe.
Comment 1 Mathieu Arnold freebsd_committer 2017-12-27 13:52:41 UTC
Created attachment 189129 [details]
v2
Comment 2 Mathieu Arnold freebsd_committer 2017-12-27 16:43:14 UTC
Created attachment 189137 [details]
v3
Comment 3 Mathieu Arnold freebsd_committer 2017-12-28 12:15:43 UTC
Created attachment 189156 [details]
v4

Add some more stuff to the mix :-)
Comment 4 Antoine Brodin freebsd_committer 2018-01-04 12:24:28 UTC
Exp-run results on 11.1 i386:

http://package23.nyi.freebsd.org/build.html?mastername=111i386-default-PR224613&build=2018-01-02_19h53m22s

New failures:

+ {"origin"=>"cad/calculix-ccx", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"databases/libdrizzle", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/cvsweb", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"devel/cvsweb3", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"devel/fpc-symbolic", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"devel/motor", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"dns/dnsjava", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"games/scummvm-tools", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"graphics/povray37", "phase"=>"stage", "errortype"=>"???"}
+ {"origin"=>"graphics/xfig", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"lang/icon", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"multimedia/mlt", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"net/httpry", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"security/cyrus-sasl2-saslauthd", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/elasticsearch", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/elasticsearch2", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/elasticsearch5", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/uim", "phase"=>"package", "errortype"=>"???"}
Comment 5 Antoine Brodin freebsd_committer 2018-01-04 12:26:32 UTC
Exp-run results on 10.3 amd64:

http://package22.nyi.freebsd.org/build.html?mastername=103amd64-default-PR224613&build=2018-01-02_19h53m21s

New failures:

+ {"origin"=>"cad/calculix-ccx", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"databases/libdrizzle", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/cvsweb", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"devel/cvsweb3", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"devel/fpc-symbolic", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"devel/motor", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"dns/dnsjava", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"games/scummvm-tools", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"graphics/povray37", "phase"=>"stage", "errortype"=>"???"}
+ {"origin"=>"graphics/xfig", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"lang/icon", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"multimedia/mlt", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"net/httpry", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"security/cyrus-sasl2-saslauthd", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/elasticsearch", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/elasticsearch2", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/elasticsearch5", "phase"=>"package", "errortype"=>"???"}
+ {"origin"=>"textproc/uim", "phase"=>"package", "errortype"=>"???"}
Comment 6 Mathieu Arnold freebsd_committer 2018-01-04 13:43:37 UTC
multimedia/mlt seems to be related to the addition of USES=eigen to graphics/movit no ?
Comment 7 Mathieu Arnold freebsd_committer 2018-01-04 13:52:30 UTC
Yes, fixing movit.
Comment 8 Mathieu Arnold freebsd_committer 2018-01-04 15:13:44 UTC
Created attachment 189401 [details]
v5

fix fallout.
Comment 9 Antoine Brodin freebsd_committer 2018-01-09 06:51:32 UTC
Exp-run looks fine.
Comment 10 commit-hook freebsd_committer 2018-01-09 07:41:32 UTC
A commit references this bug:

Author: mat
Date: Tue Jan  9 07:40:57 UTC 2018
New revision: 458513
URL: https://svnweb.freebsd.org/changeset/ports/458513

Log:
  Remove support for variables that have been deprecated for a while.

  variables                  deprecation       revision
  WITHOUT_NLS                2013-12-13        r336337
  WITH_/WITHOUT_             2014-02-24        r345870
  NOPORT(DOC|EXAMPLE)S       2014-04-19        r351587
  WITH_BDB_VER               2016-05-02        r414444
  OVERRIDE_LINUX_BASE_PORT   2016-09-05        r421387
  WITH_OPENSSL_(BASE|PORT)   2016-06-16        r416965

  While there, add an ERROR variable that works like DEV_ERROR, but for
  user facing errors, and move NOPORTDOCS,
  NOPORTEXAMPLES and WITHOUT_NLS to it.

  Cleanup bsd.sanity.mk a bit.

  Fix fallout.

  PR:		224613
  Submitted by:	mat
  Exp-run by:	antoine
  Sponsored by:	Absolight
  Differential Revision:	https://reviews.freebsd.org/D13490

Changes:
  head/Mk/Uses/bdb.mk
  head/Mk/Uses/cran.mk
  head/Mk/Uses/gem.mk
  head/Mk/bsd.default-versions.mk
  head/Mk/bsd.options.mk
  head/Mk/bsd.port.mk
  head/Mk/bsd.sanity.mk
  head/audio/chromaprint/Makefile
  head/audio/nas/Makefile.man
  head/audio/xmixer/Makefile
  head/audio/xoscope/Makefile
  head/cad/calculix-ccx/Makefile
  head/chinese/libtabe/Makefile
  head/chinese/p5-Lingua-ZH-TaBE/Makefile
  head/databases/libdrizzle/Makefile
  head/databases/libdrizzle/pkg-plist
  head/databases/ruby-bdb/Makefile
  head/devel/cvsweb/Makefile
  head/devel/cvsweb3/Makefile
  head/devel/motor/Makefile
  head/dns/dnsjava/Makefile
  head/games/scummvm-tools/Makefile
  head/graphics/mscgen/Makefile
  head/graphics/povray37/Makefile
  head/graphics/xfig/Makefile
  head/lang/fpc/Makefile
  head/lang/icon/Makefile
  head/mail/fastforward/Makefile
  head/net/httpry/Makefile
  head/net/p5-Net-Proxy/Makefile
  head/net/ssltunnel-client/Makefile
  head/net-mgmt/jnettop/Makefile
  head/news/golded+/Makefile
  head/news/leafnode/Makefile
  head/security/cyrus-sasl2/Makefile.common
  head/security/p5-SAVI-Perl/Makefile
  head/security/samhain/Makefile
  head/sysutils/grub2-pcbsd/Makefile
  head/sysutils/webjob/Makefile
  head/textproc/elasticsearch/Makefile
  head/textproc/elasticsearch2/Makefile
  head/textproc/elasticsearch5/Makefile
  head/textproc/par/Makefile
  head/textproc/uim/Makefile
  head/www/rubygem-passenger/Makefile
  head/x11-toolkits/tk86/Makefile.man