Bug 224634 - /usr/ports/Tools/scripts/mfh offers to re-edit message, but commits again on 'y'
Summary: /usr/ports/Tools/scripts/mfh offers to re-edit message, but commits again on 'y'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-28 09:45 UTC by Yuri Victorovich
Modified: 2017-12-29 13:21 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-12-28 09:45:44 UTC
An error occurred, but it doesm't allow to correct the message:

---session log---
commit.txt: 6 lines, 169 characters.
Sending        2017Q4
Sending        2017Q4/security/tor/Makefile
Sending        2017Q4/security/tor/distinfo
Transmitting file data ..done
Committing transaction...
svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
**** You need "Approved by: (portmgr|ports-secteam)" line in your log entry.

Commit failed. Re-edit message and try again? [y/n] y
Sending        2017Q4
Sending        2017Q4/security/tor/Makefile
Sending        2017Q4/security/tor/distinfo
Transmitting file data ..done
Committing transaction...
svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
**** You need "Approved by: (portmgr|ports-secteam)" line in your log entry.

Commit failed. Re-edit message and try again? [y/n] y
Sending        2017Q4
Sending        2017Q4/security/tor/Makefile
Sending        2017Q4/security/tor/distinfo
Transmitting file data ..done
Committing transaction...
svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
**** You need "Approved by: (portmgr|ports-secteam)" line in your log entry.

Commit failed. Re-edit message and try again? [y/n]
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-12-29 13:21:05 UTC
A commit references this bug:

Author: mat
Date: Fri Dec 29 13:20:47 UTC 2017
New revision: 457506
URL: https://svnweb.freebsd.org/changeset/ports/457506

Log:
  Follow up on last commit and actually allow editing
  the commit message again.

  PR:		224634
  Reported by:	yuri
  Sponsored by:	Absolight

Changes:
  head/Tools/scripts/mfh