Bug 224737 - ports-mgmt/dialog4ports: Implemented "OPTIONS_SECTION_ORDER" feature allowing to order sections
Summary: ports-mgmt/dialog4ports: Implemented "OPTIONS_SECTION_ORDER" feature allowing...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://reviews.freebsd.org/D13701
Keywords:
Depends on:
Blocks: 224467
  Show dependency treegraph
 
Reported: 2017-12-30 22:40 UTC by Yuri Victorovich
Modified: 2018-04-09 18:49 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rum1cro)


Attachments
patch (7.21 KB, patch)
2017-12-30 22:41 UTC, Yuri Victorovich
no flags Details | Diff
supporting patch to Mk/bsd.port.mk (447 bytes, patch)
2017-12-30 22:44 UTC, Yuri Victorovich
no flags Details | Diff
dialog4ports.patch (10.99 KB, patch)
2018-02-01 07:57 UTC, Yuri Victorovich
yuri: maintainer-approval? (rum1cro)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2017-12-30 22:40:55 UTC
Currently they aren't ordered between GROUP, MULTI, RADIO, and SINGLE.

Supplying the order in OPTIONS_SECTION_ORDER allows to set the overall order of sections.
Comment 1 Yuri Victorovich freebsd_committer 2017-12-30 22:41:19 UTC
Created attachment 189231 [details]
patch
Comment 2 Yuri Victorovich freebsd_committer 2017-12-30 22:44:39 UTC
Created attachment 189232 [details]
supporting patch to Mk/bsd.port.mk
Comment 3 m1cro 2017-12-31 00:15:32 UTC
Sorry, can't review it till 8 January(vacation).
But if it will reviewed by bapt@ or bdrewery@ then it will be fine for me too.
Comment 4 Yuri Victorovich freebsd_committer 2017-12-31 00:21:03 UTC
(In reply to m1cro from comment #3)

Thank you for your quick reply.
I will add this item to reviews.freebsd.org then with them as reviewers.
Comment 5 Yuri Victorovich freebsd_committer 2018-01-09 05:48:46 UTC
(In reply to m1cro from comment #3)

FYI: The above-mentioned people didn't touch it during this period.
Comment 6 Yuri Victorovich freebsd_committer 2018-01-10 07:29:31 UTC
The pending 14-day maintainer timeout expiration date: 01/12/2018.
Comment 7 m1cro 2018-01-11 22:24:30 UTC
Give me please 3 days till monday(15.01.2018)
Comment 8 Yuri Victorovich freebsd_committer 2018-01-11 22:28:40 UTC
(In reply to m1cro from comment #7)

Ok!
Comment 9 Yuri Victorovich freebsd_committer 2018-02-01 07:57:57 UTC
Created attachment 190241 [details]
dialog4ports.patch

Renamed structures to make very clear what they stand for.
Comment 10 m1cro 2018-02-02 10:00:11 UTC
I'll commit it to d4p and release new version soon.
Comment 11 Yuri Victorovich freebsd_committer 2018-04-09 17:50:51 UTC
So, can I commit it?
Comment 12 m1cro 2018-04-09 18:49:28 UTC
No, there are some issue