Bug 224808 - New x11-fonts/nerd-fonts-complete 1.2.0
Summary: New x11-fonts/nerd-fonts-complete 1.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-01 05:03 UTC by Greg Fitzgerald
Modified: 2018-01-01 16:59 UTC (History)
1 user (show)

See Also:


Attachments
nerdfont.diff (29.81 KB, patch)
2018-01-01 05:03 UTC, Greg Fitzgerald
no flags Details | Diff
nerdfont.diff (29.95 KB, patch)
2018-01-01 05:41 UTC, Greg Fitzgerald
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Fitzgerald 2018-01-01 05:03:53 UTC
Created attachment 189306 [details]
nerdfont.diff
Comment 1 Joseph Mingrone freebsd_committer 2018-01-01 05:21:07 UTC
- You need to start with the line
# $FreeBSD$

- Why not PORTNAME=nerd-fonts, then you can remove GH_PROJECT= nerd-fonts.

- COMMENT is too long and should not start with 'A".  Maybe:
COMMENT=Collection of over 20 patched fonts

- The block order should conform to 'Order of Variables in Port Makefiles' in the Porter's Handbook.
USES=		fonts
USE_GITHUB=	yes
GH_ACCOUNT=	ryanoasis

NO_ARCH=	yes
NO_BUILD=	yes

There are pkg-plist issues because of empty directories.  Maybe add this to the do-install target.

	@${RMDIR} ${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked/complete \
		${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked \
		${STAGEDIR}${FONTSDIR}/ProFont/profont-x11 \
		${STAGEDIR}${FONTSDIR}/Terminus/BDF \
		${STAGEDIR}${FONTSDIR}/Terminus/PCF \
		${STAGEDIR}${FONTSDIR}/Terminus/PSF \

ports-mgmt/portlint is helpful for detecting issues (but is not perfect).
Comment 2 Greg Fitzgerald 2018-01-01 05:41:11 UTC
Created attachment 189307 [details]
nerdfont.diff
Comment 3 commit-hook freebsd_committer 2018-01-01 16:52:46 UTC
A commit references this bug:

Author: jrm
Date: Mon Jan  1 16:52:09 UTC 2018
New revision: 457785
URL: https://svnweb.freebsd.org/changeset/ports/457785

Log:
  New port, x11-fonts/nerd-fonts: Developer-targeted fonts with glyphs

  PR:		224808
  Submitted by:	gregf@hugops.pw (maintainer)
  Reviewed by:	brd

Changes:
  head/x11-fonts/Makefile
  head/x11-fonts/nerd-fonts/
  head/x11-fonts/nerd-fonts/Makefile
  head/x11-fonts/nerd-fonts/distinfo
  head/x11-fonts/nerd-fonts/pkg-descr
  head/x11-fonts/nerd-fonts/pkg-plist