Bug 224835 - devel/codeblocks: update to 17.12
Summary: devel/codeblocks: update to 17.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-01-02 06:05 UTC by Loïc Bartoletti
Modified: 2018-02-02 10:05 UTC (History)
1 user (show)

See Also:
lbartoletti: maintainer-feedback+
riggs: merge-quarterly-


Attachments
codeblocks-17.12 (15.05 KB, patch)
2018-01-02 06:05 UTC, Loïc Bartoletti
lbartoletti: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer 2018-01-02 06:05:12 UTC
Created attachment 189331 [details]
codeblocks-17.12

New Code::Blocks release 17.12 has arrived, many improvements, new features, more stable.

Here the change log:
http://www.codeblocks.org/downloads/binaries/changelog

Porlint ok
Poudriere 10, 11 i386/amd64

Tested on 11 amd64 without crashes (see bug #223826, bug #197888), so I request a merge-quarterly
Comment 1 Thomas Zander freebsd_committer 2018-01-06 13:24:18 UTC
I am getting this build failure on stable/11 in poudriere (Jail OSVERSION: 1101506) using clang 5.0.0:

--- sqvm.lo ---
In file included from sqvm.cpp:5:
In file included from /usr/include/c++/v1/math.h:310:
/usr/include/c++/v1/limits:148:85: error: expected expression
    _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type min() _NOEXCEPT {return type();}
                                                                                    ^
../../../../src/include/scripting/squirrel/sqobject.h:99:24: note: expanded from macro 'type'
#define type(obj) ((obj)._type)
                       ^
In file included from sqvm.cpp:5:
In file included from /usr/include/c++/v1/math.h:310:
/usr/include/c++/v1/limits:148:61: error: no return statement in constexpr function
    _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type min() _NOEXCEPT {return type();}
                                                            ^
/usr/include/c++/v1/limits:149:85: error: expected expression
    _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type max() _NOEXCEPT {return type();}

Could you take a look? Thanks!
Comment 2 Loïc Bartoletti freebsd_committer 2018-01-06 19:15:00 UTC
Hi,

Thank you for the review. Can you apply this patch https://bz-attachments.freebsd.org/attachment.cgi?id=187147 from bug #222990?
Comment 3 Thomas Zander freebsd_committer 2018-01-07 08:48:41 UTC
(In reply to lbartoletti from comment #2)

Thanks for the quick response, this resolves the issue!
Comment 4 commit-hook freebsd_committer 2018-01-07 09:00:47 UTC
A commit references this bug:

Author: riggs
Date: Sun Jan  7 09:00:37 UTC 2018
New revision: 458306
URL: https://svnweb.freebsd.org/changeset/ports/458306

Log:
  Update to upstream release 17.12

  Details:
  - New release 17.12, changelog on
    http://www.codeblocks.org/downloads/binaries/changelog
  - This includes fixes for stability of the application
    which should allow to close bug #223826 and bug #197888

  PR:		224835
  Submitted by:	lbartoletti@tuxfamily.org (maintainer)
  MFH:		2018Q1

Changes:
  head/devel/codeblocks/Makefile
  head/devel/codeblocks/distinfo
  head/devel/codeblocks/files/patch-src_sdk_scripting_squirrel_sqvm.cpp
  head/devel/codeblocks/files/patch-src_sdk_wxscintilla_src_ScintillaWX.cpp
  head/devel/codeblocks/pkg-plist
Comment 5 commit-hook freebsd_committer 2018-02-02 10:05:54 UTC
A commit references this bug:

Author: feld
Date: Fri Feb  2 10:05:19 UTC 2018
New revision: 460691
URL: https://svnweb.freebsd.org/changeset/ports/460691

Log:
  MFH: r458306

  Update to upstream release 17.12

  Details:
  - New release 17.12, changelog on
    http://www.codeblocks.org/downloads/binaries/changelog
  - This includes fixes for stability of the application
    which should allow to close bug #223826 and bug #197888

  PR:		224835
  Submitted by:	lbartoletti@tuxfamily.org (maintainer)

Changes:
_U  branches/2018Q1/
  branches/2018Q1/devel/codeblocks/Makefile
  branches/2018Q1/devel/codeblocks/distinfo
  branches/2018Q1/devel/codeblocks/files/patch-src_sdk_scripting_squirrel_sqvm.cpp
  branches/2018Q1/devel/codeblocks/files/patch-src_sdk_wxscintilla_src_ScintillaWX.cpp
  branches/2018Q1/devel/codeblocks/pkg-plist