Bug 224942 - emulators/mupen64plus-qt: Fix broken dependency and update to Qt5
Summary: emulators/mupen64plus-qt: Fix broken dependency and update to Qt5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://reviews.freebsd.org/D14795
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-05 20:41 UTC by Dan
Modified: 2018-03-24 22:20 UTC (History)
1 user (show)

See Also:

Attachments
Makefile.diff (1.54 KB, patch)
2018-01-05 20:41 UTC, Dan 		no flags Details | Diff
Makefile.diff (1.55 KB, patch)
2018-01-05 20:46 UTC, Dan 		maintainer: maintainer-approval+
Details | Diff
mupen64plus-qt.diff (2.16 KB, patch)
2018-01-25 20:46 UTC, Dan 		maintainer: maintainer-approval+
Details | Diff
mupen64plus-qt.diff (2.35 KB, patch)
2018-03-12 19:05 UTC, Dan 		maintainer: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan 2018-01-05 20:41:41 UTC 
Created attachment 189452 [details]
Makefile.diff

Changes:

- Fix wrong dependency on emulators/mupen64plus
- Update port to use Qt5
Comment 1 Dan 2018-01-05 20:46:05 UTC 
Created attachment 189453 [details]
Makefile.diff
Comment 2 Dan 2018-01-25 20:46:11 UTC 
Created attachment 190065 [details]
mupen64plus-qt.diff

Version 1.11 of the application was released, so I've updated the diff to include those changes as well.
Comment 3 Dan 2018-03-06 20:33:46 UTC 
Any action to get this updated? The port is marked as deprecated and will expire in two weeks even though the fix is here.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-07 01:37:46 UTC 
A commit references this bug:

Author: linimon
Date: Wed Mar  7 01:37:09 UTC 2018
New revision: 463773
URL: https://svnweb.freebsd.org/changeset/ports/463773

Log:
  Extend expiration time per PR 224942 noting that a fix is available.

  PR:		224942
  Submitted by:	maintainer

Changes:
  head/emulators/mupen64plus-qt/Makefile
Comment 5 Dan 2018-03-12 19:05:04 UTC 
Created attachment 191454 [details]
mupen64plus-qt.diff

Why was this closed? As far as I can tell the patch here was never implemented.

I've updated the diff against the latest version 1.10_1 in the ports tree.
Comment 6 Dan 2018-03-12 19:06:38 UTC 
Setting bug to open: port has not been updated.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-12 20:48:37 UTC 
(In reply to Dan from comment #5)

Sorry, it was closed by mistake.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2018-03-20 22:30:15 UTC 
I'll take this.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2018-03-22 22:32:34 UTC 
Hi Dan,

The original patch did not compile, widgets was missing from USE_QT5. There is a review at https://reviews.freebsd.org/D14795
Are you OK with the changes?
Comment 10 Dan 2018-03-23 02:15:00 UTC 
The changes to the patch look good to me. Thank you
Comment 11 commit-hook freebsd_committer freebsd_triage 2018-03-24 19:22:35 UTC 
A commit references this bug:

Author: fernape
Date: Sat Mar 24 19:21:56 UTC 2018
New revision: 465466
URL: https://svnweb.freebsd.org/changeset/ports/465466

Log:
  PR:	224942
  Submitted by:	maintainer@hasting.email
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D14795

Changes:
  head/emulators/mupen64plus-qt/Makefile
  head/emulators/mupen64plus-qt/distinfo
Comment 12 Fernando Apesteguía freebsd_committer freebsd_triage 2018-03-24 19:24:56 UTC 
Committed,

Thanks!
Comment 13 Dan 2018-03-24 22:20:10 UTC 
Awesome. Thanks Fernando!