Bug 225103 - New port: x11-drivers/xf86-video-qxl: X.Org X server -- QXL display driver
Summary: New port: x11-drivers/xf86-video-qxl: X.Org X server -- QXL display driver
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-12 11:53 UTC by Oleg Ginzburg
Modified: 2018-01-16 17:50 UTC (History)
1 user (show)

See Also:

Attachments
new port: x11-drivers/xf86-video-qxl (4.10 KB, text/plain)
2018-01-12 11:53 UTC, Oleg Ginzburg 		olevole: maintainer-approval+
Details
updated port (1.41 KB, application/gzip)
2018-01-15 09:21 UTC, Roman Bogorodskiy 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Ginzburg 2018-01-12 11:53:17 UTC 
Created attachment 189646 [details]
new port: x11-drivers/xf86-video-qxl

New port: X.Org X server -- QXL display driver

Hint: 
This port must be processed after this issue:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225088
Comment 1 Roman Bogorodskiy freebsd_committer freebsd_triage 2018-01-15 09:21:56 UTC 
Created attachment 189737 [details]
updated port

I've updated libspice-server to generate a proper .pc file: https://reviews.freebsd.org/D13896

With this we no longer need to pass flags using CONFIGURE_ENV. Also, I made some other minor changes like s/PORTVERSION/DISTVERSION/. I also used LIB_DEPENDS instead of BUILD_DEPENDS + RUN_DEPENDS for libspice-server shared library. The only question for now is why do we need to have spice-protocol in RUN_DEPENDS as it only provides header files and I assume it's needed only for build?
Comment 2 Oleg Ginzburg 2018-01-16 08:43:14 UTC 
(In reply to Roman Bogorodskiy from comment #1)
The proposed fixes work for me. The port does not use the spice-protocol directly, but spice-protocol used (through libspice-server) when qxl work.

In the QXL documentation is written that you must have spice-protocol >= 0.12.0 and spice-protocol-dev:

README.xspice:sudo yum install spice-server-devel spice-protocol
README.xspice:This assumes you already have spice-protocol and spice-server

So I'm not sure that RUN_DEPEND should not contain spice-protocol
Comment 3 Oleg Ginzburg 2018-01-16 09:02:13 UTC 
upd: spice-protocol just headers, so yes, they are not needed as RUN_DEPENDS
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-01-16 17:48:10 UTC 
A commit references this bug:

Author: novel
Date: Tue Jan 16 17:47:10 UTC 2018
New revision: 459199
URL: https://svnweb.freebsd.org/changeset/ports/459199

Log:
  This package contains the X.Org xf86-video-qxl driver.

  WWW: https://www.x.org/

  PR:		225103
  Submitted by:	olevole@olevole.ru

Changes:
  head/x11-drivers/Makefile
  head/x11-drivers/xf86-video-qxl/
  head/x11-drivers/xf86-video-qxl/Makefile
  head/x11-drivers/xf86-video-qxl/distinfo
  head/x11-drivers/xf86-video-qxl/files/
  head/x11-drivers/xf86-video-qxl/files/patch-qxl_option_helpers.h
  head/x11-drivers/xf86-video-qxl/files/patch-spiceqxl_audio.c
  head/x11-drivers/xf86-video-qxl/pkg-descr
  head/x11-drivers/xf86-video-qxl/pkg-plist
Comment 5 Roman Bogorodskiy freebsd_committer freebsd_triage 2018-01-16 17:50:11 UTC 
Committed, thanks!