Bug 225149 - net/haproxy: Fix openssl linking
Summary: net/haproxy: Fix openssl linking
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-01-13 22:30 UTC by Bernard Spil
Modified: 2018-01-15 21:14 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (demon)


Attachments
svn diff for net/haproxy (2.23 KB, patch)
2018-01-13 22:30 UTC, Bernard Spil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2018-01-13 22:30:35 UTC
Created attachment 189694 [details]
svn diff for net/haproxy

I was notified of an issue when using haproxy with BoringSSL. It was linking base libssl and libcrypto even though BoringSSL was set as ssl provider.
Whilst in the Makefile I migrated to the new Options framework. The LIB_DEPENDS for static PCRE was set to the dynamic .so lib file as the static .a files in the pcre port are not optional (i.e. will always be available when devel/pcre is installed).
The port now forces the SSL lib and include dir so it will link correctly.

Proposed commit msg
```
net/haproxy: Fix SSL linking

 - Pass lib and include paths to make
 - Optionsify

PR:
Submitted by: brnrd
Approved by: ... (maintainer)
```
Comment 1 Dmitry Sivachenko freebsd_committer 2018-01-15 07:41:04 UTC
The patch looks fine for me, but please also make the same changes to net/haproxy-devel port.

Thanks!
Comment 2 commit-hook freebsd_committer 2018-01-15 21:11:00 UTC
A commit references this bug:

Author: brnrd
Date: Mon Jan 15 21:10:53 UTC 2018
New revision: 459115
URL: https://svnweb.freebsd.org/changeset/ports/459115

Log:
  net/haproxy-devel: Fix linking SSL libs

   - Pass lib and include paths to make
   - Optionsify

  PR:		225149
  Approved by:	demon (maintainer)

Changes:
  head/net/haproxy-devel/Makefile
Comment 3 Bernard Spil freebsd_committer 2018-01-15 21:14:05 UTC
The build error on -devel on 10.x is pre-existing.
Comment 4 commit-hook freebsd_committer 2018-01-15 21:14:06 UTC
A commit references this bug:

Author: brnrd
Date: Mon Jan 15 21:12:58 UTC 2018
New revision: 459116
URL: https://svnweb.freebsd.org/changeset/ports/459116

Log:
  net/haproxy: Fix linking SSL libs

   - Pass lib and include paths to make
   - Optionsify

  PR:             225149
  Approved by:    demon (maintainer)

Changes:
  head/net/haproxy/Makefile