Created attachment 189758 [details]
Proposed patch (since 441503 revision)

Patch to fix build of games/diaspora port for newer Clang and GCC compilers, which uses -std=gnu++14 for C++ files by default:
https://github.com/llvm-mirror/clang/commit/466d8da5f89b1a780f735c86f414fa69ce63221b

Fixes following errors (reported by newer Clang from pkg-fallout@ FreeBSD 12.0-CURRENT 1200056 amd64):
-8<--
globalincs/safe_strings.cpp:42:15: error: assigning to 'char' from incompatible type 'nullptr_t'
                        *strDest = NULL;
                                   ^~~~
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^~~~~~~
globalincs/safe_strings.cpp:49:14: error: assigning to 'char' from incompatible type 'nullptr_t'
                *strDest = NULL;
                           ^~~~
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^~~~~~~
globalincs/safe_strings.cpp:61:14: error: assigning to 'char' from incompatible type 'nullptr_t'
                *strDest = NULL;
                           ^~~~
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^~~~~~~
globalincs/safe_strings.cpp:78:15: error: assigning to 'char' from incompatible type 'nullptr_t'
                        *strDest = NULL;
                                   ^~~~
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^~~~~~~
globalincs/safe_strings.cpp:85:14: error: assigning to 'char' from incompatible type 'nullptr_t'
                *strDest = NULL;
                           ^~~~
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^~~~~~~
globalincs/safe_strings.cpp:101:14: error: assigning to 'char' from incompatible type 'nullptr_t'
                *strDest = NULL;
                           ^~~~
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^~~~~~~
globalincs/safe_strings.cpp:111:14: error: assigning to 'char' from incompatible type 'nullptr_t'
                *strDest = NULL;
                           ^~~~
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^~~~~~~
7 errors generated.
-->8-

- Add USE_CXXSTD=gnu++98
- Replace %%DATADIR%% to ${DATADIR} for WXLAUNCHER_PLIST_FILES variable
- Add upstream patch for code/globalincs/safe_strings.cpp

The PORTREVISION bump is not required.