Created attachment 189864 [details] tinyxml2_plist.patch ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: lib/libtinyxml2d.a Error: Orphaned: lib/libtinyxml2d.so Error: Orphaned: lib/libtinyxml2d.so.6 Error: Orphaned: lib/libtinyxml2d.so.%%PORTVERSION%% ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: lib/libtinyxml2.a Error: Missing: lib/libtinyxml2.so Error: Missing: lib/libtinyxml2.so.6 Error: Missing: lib/libtinyxml2.so.%%PORTVERSION%% ===> Error: Plist issues found. *** Error code 1 Note the output changed to 'libtinyxml2d' - ABI tracker reports this occurred in the 4.0->5.0 transition. https://abi-laboratory.pro/tracker/objects_report/tinyxml2/4.0.1/5.0.0/report.html Patch to resolve is attached.
This change has also broken multimedia/libmediainfo, and probably breaks some other things that I haven't found yet.
You cannot fully rely on ABI tracker results. The "d" suffix indicates you're building a debug version which is not the default configuration.
Ah crap, you're right, I missed removing one of my DEBUG flags here. Still, that's a problem. Just of a different sort. If I build tinyxml2 WITH_DEBUG=1 that should not be breaking the port or things that depend on the port. But, that's exactly what happens right now. I'm a lot less sure how to fix that though.
I could add a DEBUG option to handle the PLIST issue. Try this patch and enable DEBUG option. But I haven't tested if libmediainfo recognizes tinyxml2 with "d" suffix. https://people.FreeBSD.org/~sunpoet/patch/textproc-tinyxml2.txt
That seems eminently reasonable to me; didn't know that was possible to do with plist. libmediainfo definitely does not know how to handle the d suffix when debug is enabled, and causes a lib-depends fail. I'm not sure how to handle that one gracefully. Is there even a standard way to specify different LIB_DEPENDS based on DEBUG versus not? This seems like a problem that may have to be acceptable breakage during DEBUG.
Hmm, it looks like the simplest solution is to remove the "d" suffix. libmediainfo does not recognize libtinyxml2d even if we modify the LIB_DEPENDS line in Makefile.
A commit references this bug: Author: sunpoet Date: Sun Jan 21 09:00:19 UTC 2018 New revision: 459575 URL: https://svnweb.freebsd.org/changeset/ports/459575 Log: Fix packaging with WITH_DEBUG defined PR: 225282 Reported by: Phillip R. Jaenke <prj@rootwyrm.com> Changes: head/textproc/tinyxml2/Makefile