Bug 225347 - x11-toolkits/qt5-quickcontrols: some pkg-plist files wrongly marked as DEBUG
Summary: x11-toolkits/qt5-quickcontrols: some pkg-plist files wrongly marked as DEBUG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-21 03:12 UTC by Tomasz Kowalczyk
Modified: 2018-01-21 11:47 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback+

Attachments
suggested change (4.37 KB, patch)
2018-01-21 03:12 UTC, Tomasz Kowalczyk 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Kowalczyk 2018-01-21 03:12:52 UTC 
Created attachment 189939 [details]
suggested change

Some files are marked %%DEBUG%% in pkg-plist, but they need to be installed so plasma configure dialogs are working at all. Without them installed many windows not showing at all: for example desktop configuration window. It shows only small empty border without any content.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-01-21 11:47:08 UTC 
A commit references this bug:

Author: rakuco
Date: Sun Jan 21 11:46:48 UTC 2018
New revision: 459589
URL: https://svnweb.freebsd.org/changeset/ports/459589

Log:
  Drop %%DEBUG%% from several plist entries.

  Those items were added with %%DEBUG%% when we updated Qt to 5.3.2. At the time,
  src/dialogs/dialogs.pro had the following excerpt:

      # In case of a debug build, deploy the QML files too
      CONFIG(debug, debug|release): QML_FILES += $$DIALOGS_QML_FILES

  but that actually changed in Qt 5.9.0, which dropped the check altogether and
  always adds those files to QML_FILES.

  Not shipping them causes runtime issues according to the bug report below.

  PR:		225347
  Submitted by:	Tomasz Kowalczyk <kowalczt@zoho.eu>

Changes:
  head/x11-toolkits/qt5-quickcontrols/Makefile
  head/x11-toolkits/qt5-quickcontrols/pkg-plist
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2018-01-21 11:47:55 UTC 
Thanks a lot for the patch!