Bug 225376 - [emulators/virtualbox-ose] [patch] extra dependency on sysutils/cdrtools
Summary: [emulators/virtualbox-ose] [patch] extra dependency on sysutils/cdrtools
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Eugene Grosbein
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2018-01-22 10:15 UTC by Eugene Grosbein
Modified: 2018-02-05 21:10 UTC (History)
2 users (show)

See Also:


Attachments
remove dependency on cdrtools (1.56 KB, patch)
2018-01-22 10:15 UTC, Eugene Grosbein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer 2018-01-22 10:15:43 UTC
Created attachment 189960 [details]
remove dependency on cdrtools

emulators/virtualbox-ose depends on sysutils/cdrtools to install makeisofs.

We could replace this dependency with in-base makefs that is capable to make ISO images but it is not needed too. Its configure script says:

# Check for mkisofs, needed to build the CDROM image containing the additions

In fact, VirtualBox build system does NOT use make use of makeisofs while building for FreeBSD as it does not try to buid

https://www.virtualbox.org/wiki/FreeBSD%20build%20instructions says in its Prerequisites section:

mkisofs (required only for additions which aren't supported yet)
=> /usr/ports/sysutils/cdrtools 

So, we need just drop this unneeded dependency. It was introduced over 6 years ago and was never really used:

https://svnweb.freebsd.org/ports/head/emulators/virtualbox-ose/Makefile?revision=274444&view=markup

The patch fixing this is attached.
Comment 1 commit-hook freebsd_committer 2018-02-05 21:07:33 UTC
A commit references this bug:

Author: eugen
Date: Mon Feb  5 21:06:41 UTC 2018
New revision: 461020
URL: https://svnweb.freebsd.org/changeset/ports/461020

Log:
  emulators/virtualbox-ose: remove extra dependency on cdrtools.

  Dependency on cdrtools was introduced 6 years ago for sake of mkisofs:
  https://svnweb.freebsd.org/ports/head/emulators/virtualbox-ose/Makefile?revision=274444&view=markup

  In fact, VirtualBox build system does not use makeisofs
  while building for FreeBSD because it does not even try to buid
  VirtualBox Additions ISO image as its documentation says
  in the Prerequisites section:

  	mkisofs (required only for additions which aren't supported yet)
  	=> /usr/ports/sysutils/cdrtools

  	https://www.virtualbox.org/wiki/FreeBSD%20build%20instructions

  And it never really used mkisofs.
  Drop the dependency and bump PORTREVISION.

  PR:		225376
  Approved by:	vbox (maintainer timeout, 2 weeks)

Changes:
  head/emulators/virtualbox-ose/Makefile
  head/emulators/virtualbox-ose/files/patch-configure