Bug 225462 - comms/uhd: various cleanups including non-default LOCALBASE / PREFIX, option handling & plist fixes
Summary: comms/uhd: various cleanups including non-default LOCALBASE / PREFIX, option ...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Michael Reifenberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-25 23:00 UTC by John Hein
Modified: 2018-10-22 14:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mr)


Attachments
[patch] various cleanups including non-default LOCALBASE / PREFIX, option handling & plist fixes (103.26 KB, patch)
2018-01-25 23:00 UTC, John Hein
no flags Details | Diff
[patch] [v2] various cleanups including non-default LOCALBASE / PREFIX, option handling & plist fixes (103.28 KB, patch)
2018-02-24 11:44 UTC, John Hein
jcfyecrayz: maintainer-approval? (mr)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2018-01-25 23:00:28 UTC
Created attachment 190071 [details]
[patch] various cleanups including non-default LOCALBASE / PREFIX, option handling & plist fixes

================
Remove libdata/pkgconfig patch (see fixup-lib-pkgconfig in bsd.port.mk - 20170606).

Promote devel/boost-libs from BUILD_DEPENDS to LIB_DEPENDS (noticed by stage-qa).

Explicitly disable doxygen manual gen / install.  Before this, if case doxygen is detected, it will gen/install dox output even if DOXYGEN option is off. Fix plist for doxygen option.  check-orphans now passes with DOXYGEN on and off.

Remove old style option handling cruft.

Stop hacking cmake_install.cmake and use default do-install.  This makes LOCALBASE != /usr/local and PREFIX != LOCALBASE work (/usr/local was bogusly hard-coded anyway).

There's a bunch of files with CR line endings; fix with USES=dos2unix.

Addressed a few portlint issues.

Add LICENSE (with a comment about the Ettus Alternate License).

Fix WWW URL(s) in pkg-descr.
==================

Note: Re: portlint - I did not regen patches (makepatch) since those were not changed.  I feel doing that is just unnecessary repo churn.  If the committer feels strongly otherwise, feel free to regen patches with makepatch and retest.

QA testing:
 - poudriere testport: ok (with DOXYGEN on/off)
 - portlint: fixed some (Makefile ordering mostly), no new issues, no errors
Comment 1 John Hein 2018-01-26 02:14:57 UTC
Also note: there should be no package change here, so I don't think a PORTREVISION bump is needed.
Comment 2 John Hein 2018-02-24 11:44:19 UTC
Created attachment 190953 [details]
[patch] [v2] various cleanups including non-default LOCALBASE / PREFIX, option handling & plist fixes

r462257 updated this port.  Most of the cleanups here are still applicable.

Attached is a refreshed patch.

devel/boost-libs was promoted to LIB_DEPENDS in r462257.

Updated summary of changes (only removed the note about the boost-libs promotion):

================
Remove libdata/pkgconfig patch (see fixup-lib-pkgconfig in bsd.port.mk - 20170606).

Explicitly disable doxygen manual gen / install.  Before this, if case doxygen is detected, it will gen/install dox output even if DOXYGEN option is off. Fix plist for doxygen option.  check-orphans now passes with DOXYGEN on and off.

Remove old style option handling cruft.

Stop hacking cmake_install.cmake and use default do-install.  This makes LOCALBASE != /usr/local and PREFIX != LOCALBASE work (/usr/local was bogusly hard-coded anyway).

There's a bunch of files with CR line endings; fix with USES=dos2unix.

Addressed a few portlint issues.

Add LICENSE (with a comment about the Ettus Alternate License).

Fix WWW URL(s) in pkg-descr.
==================

Otherwise, the original description & comment 1 are the same.
Comment 3 John Hein 2018-04-16 14:44:21 UTC
Has this been reviewed?  Any comments?
Comment 4 John Hein 2018-10-09 13:54:03 UTC
ping?
Comment 5 Michael Reifenberger freebsd_committer 2018-10-22 14:32:00 UTC
Hi,
Im deeply sorry for the long delay.

The patch as is look good.
I just can't check with poudriere because py27 has an installation issue
and py37 has no py-cheetah...

Greetings
---
Mike