Bug 225529 - sysutils/py-salt: Add patches to get the hostuuid more reliably
Summary: sysutils/py-salt: Add patches to get the hostuuid more reliably
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Luca Pizzamiglio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-29 11:25 UTC by Fabian Keil
Modified: 2020-03-06 23:00 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (christer.edwards)


Attachments
sysutils/py-salt: Add patches to get the hostuuid more reliably (3.60 KB, patch)
2018-01-29 11:25 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2018-01-29 11:25:04 UTC
Created attachment 190153 [details]
sysutils/py-salt: Add patches to get the hostuuid more reliably

The attached patch lets _hw_data() validate the kenv output on
FreeBSD-based systems

Previously systems running in bhyve without smbios had a couple
of grains with the value 'kenv: unable to get ...'.

With the patch the kenv output is only used if it looks legit.

Additionally _hw_data() is modified to fallback to the hostuuid sysctl
when the FreeBSD-based system doesn't have a hardware uuid.

For systems running in bhyve there may not be a "hardware" uuid
but the hostuuid rc.d script whil generate a hostuuid from other
system properties and populate kern.hostuuid with it.
Comment 1 Christer Edwards 2018-03-06 18:56:36 UTC
I'll approve these patches if they have also been submitted upstream to SaltStack.
Comment 2 Steve Wills freebsd_committer 2019-04-30 13:19:10 UTC
Any status change or update here?
Comment 3 Christer Edwards 2019-05-25 14:40:44 UTC
I tried comparing upstream but there has been too much drift. +1 to close.

If this still needs a fix, it will need to be recreated against current.
Comment 4 Ben Woods freebsd_committer 2020-03-06 23:00:48 UTC
(In reply to Christer Edwards from comment #3)
Closing this bug report as per comment #3