Bug 225538 - cad/stepcode Fix 12-current build
Summary: cad/stepcode Fix 12-current build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-29 17:58 UTC by Fernando Apesteguía
Modified: 2018-02-02 09:50 UTC (History)
2 users (show)

See Also:


Attachments
patch to the ports tree (1.86 KB, patch)
2018-01-29 17:58 UTC, Fernando Apesteguía
fernape: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Apesteguía freebsd_committer 2018-01-29 17:58:11 UTC
Created attachment 190166 [details]
patch to the ports tree

Since clang 6.0.0 was imported, cad/stepcode does not build in 12-CURRENT.
The attached patch addresses this issue.

See the relevant discussion here:

https://lists.freebsd.org/pipermail/freebsd-hackers/2018-January/052209.html

Q/A:
 - portlint -AC: OK
 - 12-CURRENT r328126 i386: OK
 - 12-CURRENT r328383 amd64: OK
 - poudriere builds for {10.3,10.4,11.1}{amd64,i386}: OK. Logs avaiable at: https://www.dropbox.com/sh/0wqlu6svd6ukx00/AADQp30houtf5CyPVK1f6hPZa?dl=0
Comment 1 Fernando Apesteguía freebsd_committer 2018-01-29 18:09:33 UTC
I forgot to mention this is kind of fixed in the upstream project:

https://github.com/stepcode/stepcode/blob/master/src/base/judy/src/judyL2Array.h

It assigns to NULL instead of nullptr. However there is no official release yet.
Comment 2 commit-hook freebsd_committer 2018-02-02 09:49:32 UTC
A commit references this bug:

Author: danfe
Date: Fri Feb  2 09:48:48 UTC 2018
New revision: 460682
URL: https://svnweb.freebsd.org/changeset/ports/460682

Log:
  Unbreak the build against recent Clang.

  PR:	225538

Changes:
  head/cad/stepcode/Makefile
Comment 3 Alexey Dokuchaev freebsd_committer 2018-02-02 09:50:44 UTC
Should be fixed as of ports r460682.