Bug 225549 - sysutils/synergy fails to build with base clang
Summary: sysutils/synergy fails to build with base clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-30 01:02 UTC by Sean Bruno
Modified: 2018-01-31 16:39 UTC (History)
1 user (show)

See Also:


Attachments
Full log from poudriere (27.94 KB, text/plain)
2018-01-30 01:02 UTC, Sean Bruno
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer 2018-01-30 01:02:53 UTC
Created attachment 190182 [details]
Full log from poudriere

Snippet of buildfailure from poudriere log:

[1/146] /usr/bin/c++  -DHAVE_CONFIG_H -DSYSAPI_UNIX=1 -DWINAPI_XWINDOWS=1 -Isrc/lib/arch/.. -Isrc/lib/arch/../../.. -O2 -pipe -I/usr/local/include -L/usr/local/lib -fstack-protector -fno-strict-aliasing -fPIC -O2 -pipe -I/usr/local/includ
e -L/usr/local/lib -fstack-protector -fno-strict-aliasing -MD -MT src/lib/arch/CMakeFiles/arch.dir/Arch.cpp.o -MF src/lib/arch/CMakeFiles/arch.dir/Arch.cpp.o.d -o src/lib/arch/CMakeFiles/arch.dir/Arch.cpp.o -c src/lib/arch/Arch.cpp
FAILED: src/lib/arch/CMakeFiles/arch.dir/Arch.cpp.o 
/usr/bin/c++  -DHAVE_CONFIG_H -DSYSAPI_UNIX=1 -DWINAPI_XWINDOWS=1 -Isrc/lib/arch/.. -Isrc/lib/arch/../../.. -O2 -pipe -I/usr/local/include -L/usr/local/lib -fstack-protector -fno-strict-aliasing -fPIC -O2 -pipe -I/usr/local/include -L/usr
/local/lib -fstack-protector -fno-strict-aliasing -MD -MT src/lib/arch/CMakeFiles/arch.dir/Arch.cpp.o -MF src/lib/arch/CMakeFiles/arch.dir/Arch.cpp.o.d -o src/lib/arch/CMakeFiles/arch.dir/Arch.cpp.o -c src/lib/arch/Arch.cpp
c++: warning: argument unused during compilation: '-L/usr/local/lib' [-Wunused-command-line-argument]
c++: warning: argument unused during compilation: '-L/usr/local/lib' [-Wunused-command-line-argument]
In file included from src/lib/arch/Arch.cpp:19:
In file included from src/lib/arch/../arch/Arch.h:56:
In file included from src/lib/arch/../arch/unix/ArchDaemonUnix.h:21:
In file included from src/lib/arch/../arch/ArchDaemonNone.h:21:
In file included from src/lib/arch/../arch/IArchDaemon.h:22:
In file included from src/lib/arch/../base/String.h:22:
In file included from src/lib/arch/../common/stdstring.h:20:
In file included from /usr/include/c++/v1/string:477:
In file included from /usr/include/c++/v1/string_view:176:
/usr/include/c++/v1/__string:269:16: error: use of undeclared identifier 'NULL'
        return NULL;
               ^
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^
src/lib/arch/../common/common.h:141:18: note: expanded from macro 'nullptr'
#       define nullptr NULL
                       ^
In file included from src/lib/arch/Arch.cpp:19:
In file included from src/lib/arch/../arch/Arch.h:56:
In file included from src/lib/arch/../arch/unix/ArchDaemonUnix.h:21:
In file included from src/lib/arch/../arch/ArchDaemonNone.h:21:
In file included from src/lib/arch/../arch/IArchDaemon.h:22:
In file included from src/lib/arch/../base/String.h:22:
In file included from src/lib/arch/../common/stdstring.h:20:
In file included from /usr/include/c++/v1/string:477:
In file included from /usr/include/c++/v1/string_view:176:
/usr/include/c++/v1/__string:375:16: error: use of undeclared identifier 'NULL'
        return NULL;
               ^
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^
src/lib/arch/../common/common.h:141:18: note: expanded from macro 'nullptr'
#       define nullptr NULL
                       ^
src/lib/arch/Arch.cpp:25:30: error: use of undeclared identifier 'NULL'
Arch*                                   Arch::s_instance = NULL;
                                                           ^
/usr/include/sys/_null.h:37:14: note: expanded from macro 'NULL'
#define NULL    nullptr
                ^
src/lib/arch/../common/common.h:141:18: note: expanded from macro 'nullptr'
                       ^
5 errors generated.
ninja: build stopped: subcommand failed.
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/synergy
=>> Cleaning up wrkdir
===>  Cleaning for synergy-1.8.8
build of sysutils/synergy | synergy-1.8.8 ended at Mon Jan 29 14:28:02 MST 2018
build time: 00:00:10
!!! build failure encountered !!!
Comment 1 Sean Bruno freebsd_committer 2018-01-30 01:04:39 UTC
https://github.com/symless/synergy-core/releases

Maybe we just get to update to 2.0 and see if it goes away?
Comment 2 Sean Bruno freebsd_committer 2018-01-30 01:06:23 UTC
(In reply to Sean Bruno from comment #1)
Hmm, probably not.

https://github.com/symless/synergy-core/blob/v2.0.0-stable/src/lib/arch/Arch.cpp#L25
Comment 3 John Baldwin freebsd_committer freebsd_triage 2018-01-30 16:39:41 UTC
See https://reviews.freebsd.org/D14131
Comment 4 commit-hook freebsd_committer 2018-01-31 16:38:12 UTC
A commit references this bug:

Author: sbruno
Date: Wed Jan 31 16:37:43 UTC 2018
New revision: 460499
URL: https://svnweb.freebsd.org/changeset/ports/460499

Log:
  Fix nullptr definition buildfailure on current with clang6

  PR:		225549
  Submitted by:	jhb
  Differential Revision:	https://reviews.freebsd.org/D14131

Changes:
  head/sysutils/synergy/files/patch-src_lib_common_common.h