Created attachment 190326 [details]
Correct OPENJPEG option's function both for MASTER and SLAVES
With OPENJPEG option disabled, build of poppler-glib fails.
The problem seems to be in the graphics/poppler (master) conditional that checks whether it's a SLAVE or MASTER build. The conditional is setting OPTIONS-defined CONFIGURE_ARGS only for MASTER (though the comment for the .else section seems to think it's for SLAVES), so for slaves the missing OPENJPEG option does not set --enable-libopenjpeg to none.
As the default for that is "auto", the build fails at configure stage, looking for libopenjpeg:
> configure: error: Install libopenjpeg2 or libopenjpeg1 before trying to build poppler. You can also decide to use the internal unmaintained JPX decoder or none at all. See --help.
This patch extracts the OPENJPEG conditional outside of master-slave check (thus it applies for both), and now poppler, poppler-utils, poppler-data and poppler-glib build fine, with OPENJPEG disabled.
Please note I don't know if this breaks anything functionally, or even if it's the correct thing to do, or it is but CAIRO and CURL options need to be extracted outside of the master-slave conditional as well.
Build tested with Poudriere 11.1 amd64.
Created attachment 190327 [details]
Correct OPENJPEG option's function both for MASTER and SLAVES (2)
Just realized, the comment for .else was ! (not) SLAVE... Reverted the comment in this patch back to what it was.
Created attachment 199938 [details]
Working graphics/poppler/Makefile as of r486467
The patches provided above for this bug did not work for me w/the current version of poppler ( r486467 ). I've attached the patch I was able to use to get everything building with OPENJPEG disabled.
Is this still an issue with 0.72?