Bug 225681 - misc/wmweather+: Change location of config file
Summary: misc/wmweather+: Change location of config file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo G. Baio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-05 12:47 UTC by Rainer Hurling
Modified: 2018-02-07 00:00 UTC (History)
2 users (show)

See Also:


Attachments
patch to change location of global config file (1.34 KB, patch)
2018-02-05 12:47 UTC, Rainer Hurling
rhurlin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2018-02-05 12:47:11 UTC
Created attachment 190336 [details]
patch to change location of global config file

Because pkg-message recommended to use a config file on user level, there was no demand for a global config file before.

Cyrus Rahman submitted a patch, which changes wmweather+'s global default location from /etc to /usr/local/etc, many thanks!

The attached patch includes Cyrus submission and a hint in pkg-message to make the new place known to the users.


Testet with Poudriere (HEADa/i, 11.1a/i and 10.4a/i).
portlint -AC seems happy.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-02-06 23:50:44 UTC
A commit references this bug:

Author: dbaio
Date: Tue Feb  6 23:49:44 UTC 2018
New revision: 461116
URL: https://svnweb.freebsd.org/changeset/ports/461116

Log:
  misc/wmweather+: Change location of config file

  Update pkg-message to also inform the possibility of use a global config file.

  PR:		225681
  Submitted by:	Rainer Hurling <rhurlin@gwdg.de> (maintainer)

Changes:
  head/misc/wmweather+/Makefile
  head/misc/wmweather+/files/pkg-message.in
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2018-02-07 00:00:28 UTC
Committed with minor changes.

Do not use /usr/local [1].
And if you change the contents of the package, always increase PORTREVISION.

Thank you!

[1] - https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-prefix.html