Created attachment 190389 [details] Patch to make option WCHAR implicit This bug occurs only when the port is configured and built individually. How to reproduce: ~~~~~~~~~~~~~~~~~ Compile the port with options LUIT enabled and WCHAR disabled. What happens: ~~~~~~~~~~~~~ The port compiles without problems but the enabled option LUIT is silently ignored because it relies on the WCHAR option which was disabled. This can be verified if the configure command will be used with the following parameters: ./configure --with-luit --disable-wide-chars The option '--with-luit' is silently ignored and xterm will have no luit filter and unicode support. If the configure command as listed below will be used instead, xterm is compiled with luit filter and unicode support: ./configure --with-luit --enable-wide-chars Resolution: ~~~~~~~~~~~ The option WCHAR should be enabled implicitly when option LUIT is enabled. Attached with this PR is the patch. QA: ~~ - portlint: ok - poudriere (11.1-RELEASE amd64): ok
Created attachment 190390 [details] configure with LUIT enabled and WCHAR disabled
Created attachment 190391 [details] configure with LUIT enabled and WCHAR enabled
A commit references this bug: Author: ehaupt Date: Sat Feb 10 08:11:26 UTC 2018 New revision: 461363 URL: https://svnweb.freebsd.org/changeset/ports/461363 Log: - Update to 331 - WCHAR options requires print/freetype2 - LUIT option implies the WCHAR option [1] - Provide a TOOLBAR option [2] PR: 225733 [1] Submitted by: 180126-bugzilla_freebsd_org@k-worx.org [1], schweikh@schweikhardt.net (via mail) [2] Changes: head/x11/xterm/Makefile head/x11/xterm/distinfo
Committed, thank you very much.